[CMAKE] Cleanup secp256k1 module path
ClosedPublic
Actions

Authored by Fabien on Jan 7 2020, 16:40.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING674034a40326: [CMAKE] Cleanup secp256k1 module path
rABC674034a40326: [CMAKE] Cleanup secp256k1 module path

Summary

Now that secp256k1 has it's own project, there is no need to have it
build standalone from the bitcoin-abc source tree.
It can be selected by using the appropriated target instead.

Test Plan

ninja check check-secp256k1

ABC_BUILD_NAME=build-default ./contrib/teamcity/build-configurations.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_secp256k1_cleanup_module_path

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8766
Build 15514: Default Diff Build & Tests
Build 15513: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 7 2020, 16:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2020, 16:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4844: [CMAKE] Allow building secp256k1 as a standalone project.Jan 7 2020, 16:41

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8766: Diff 15199.Jan 7 2020, 16:45

deadalnix accepted this revision.Jan 7 2020, 17:25

deadalnix added inline comments.

contrib/teamcity/build-configurations.sh
118	check-secp256k1-java ?
124	It seems like this could benefit from running ninja check-all / ninja check-extended. This would ensure this whole test suite also covers univalue and leveldb.

This revision is now accepted and ready to land.Jan 7 2020, 17:25

Fabien added inline comments.Jan 7 2020, 17:43

contrib/teamcity/build-configurations.sh
118	`check-secp256k1` includes `check-secp256k1-java` if `-DSECP256K1_ENABLE_JNI` is `ON`.
124	It's on my stack, I just left it aside lately in favor of other stuff.