Changeset View
Changeset View
Standalone View
Standalone View
src/seeder/db.cpp
Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines | do { | ||||
} | } | ||||
if (idToInfo[ret].ignoreTill && idToInfo[ret].ignoreTill < now) { | if (idToInfo[ret].ignoreTill && idToInfo[ret].ignoreTill < now) { | ||||
ourId.push_back(ret); | ourId.push_back(ret); | ||||
idToInfo[ret].ourLastTry = now; | idToInfo[ret].ourLastTry = now; | ||||
} else { | } else { | ||||
ip.service = idToInfo[ret].ip; | ip.service = idToInfo[ret].ip; | ||||
ip.ourLastSuccess = idToInfo[ret].ourLastSuccess; | ip.ourLastSuccess = idToInfo[ret].ourLastSuccess; | ||||
ip.fReliable = idToInfo[ret].IsGood(); | |||||
jasonbcox: Now that fReliable's intent has been nailed down a bit, might I suggest a better name for it? | |||||
nakihitoAuthorUnsubmitted Done Inline ActionsActually, I think fReliable is the correct name for this variable and IsGood() should be renamed to match (see D5830). I do agree that fGood is not very good, though. nakihito: Actually, I think `fReliable` is the correct name for this variable and `IsGood()` should be… | |||||
ip.hasBeenTriedBefore = idToInfo[ret].hasBeenTriedBefore(); | |||||
ip.timeSinceFoundOrLastSuccess = | |||||
idToInfo[ret].timeSinceFoundOrLastSuccess(); | |||||
break; | break; | ||||
} | } | ||||
} while (1); | } while (1); | ||||
nDirty++; | nDirty++; | ||||
return true; | return true; | ||||
} | } | ||||
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines |
Now that fReliable's intent has been nailed down a bit, might I suggest a better name for it? isGood? Call it what it is. I know this conflicts with fGood, but that's because fGood is inconsistent with the rest of the codebase and hence it's a bad name.