Paths

Table of Contentst

Differential D5830

Rename IsGood() to IsReliable()
ClosedPublic
Actions

Authored by nakihito on Apr 24 2020, 18:38.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING2debdb2ce94c: Rename IsGood() to IsReliable()
rABC2debdb2ce94c: Rename IsGood() to IsReliable()

Summary

IsGood() is a misleading name. This function does not tell whether a
node is/was good or not. Rather, it uses the results of a
reliablity/survival function to inform the caller whether or not a node
has had reliable up-time. As such IsReliable() more properly
describes to the function.

Test Plan

ninja
ninja check-bitcoin-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 24 2020, 18:38

Owners added a reviewer: Restricted Owners Package.Apr 24 2020, 18:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 18:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito mentioned this in D5686: Implement banning logic for Seeder for nodes on the wrong chain.Apr 24 2020, 18:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10385: Diff 19092.Apr 24 2020, 18:47

jasonbcox accepted this revision.Apr 24 2020, 19:30

This revision is now accepted and ready to land.Apr 24 2020, 19:30

Closed by commit rABC2debdb2ce94c: Rename IsGood() to IsReliable() (authored by nakihito). · Explain WhyApr 24 2020, 22:30

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC2debdb2ce94c: Rename IsGood() to IsReliable().

nakihito added a commit: rSTAGING2debdb2ce94c: Rename IsGood() to IsReliable().May 5 2020, 19:07

Revision Contents
Changeset List

Path

Size

src/

seeder/

10 lines

4 lines

Diff 19100

src/seeder/db.h

Loading...

src/seeder/db.cpp

Loading...