HomePhabricator

Rename IsGood() to IsReliable()

Description

Rename IsGood() to IsReliable()

Summary:
IsGood() is a misleading name. This function does not tell whether a
node is/was good or not. Rather, it uses the results of a
reliablity/survival function to inform the caller whether or not a node
has had reliable up-time. As such IsReliable() more properly
describes to the function.

Test Plan:

ninja
ninja check-bitcoin-seeder

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5830

Details

Provenance
nakihitoAuthored on Apr 24 2020, 18:35
nakihitoPushed on Apr 24 2020, 22:30
Reviewer
Restricted Owners Package
Differential Revision
D5830: Rename IsGood() to IsReliable()
Parents
rABC94cd1f0f2b55: Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and…
Branches
Unknown
Tags
Unknown