Page MenuHomePhabricator

Rename IsGood() to IsReliable()
ClosedPublic

Authored by nakihito on Apr 24 2020, 18:38.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2debdb2ce94c: Rename IsGood() to IsReliable()
rABC2debdb2ce94c: Rename IsGood() to IsReliable()
Summary

IsGood() is a misleading name. This function does not tell whether a
node is/was good or not. Rather, it uses the results of a
reliablity/survival function to inform the caller whether or not a node
has had reliable up-time. As such IsReliable() more properly
describes to the function.

Test Plan
ninja
ninja check-bitcoin-seeder

Diff Detail

Repository
rABC Bitcoin ABC
Branch
RenameSeederIsGood
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10385
Build 18591: Default Diff Build & Tests
Build 18590: arc lint + arc unit