Changeset View
Changeset View
Standalone View
Standalone View
test/functional/wallet_importmulti.py
| #!/usr/bin/env python3 | #!/usr/bin/env python3 | ||||
| # Copyright (c) 2014-2019 The Bitcoin Core developers | # Copyright (c) 2014-2019 The Bitcoin Core developers | ||||
| # Distributed under the MIT software license, see the accompanying | # Distributed under the MIT software license, see the accompanying | ||||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||||
| """Test the importmulti RPC. | """Test the importmulti RPC. | ||||
| Test importmulti by generating keys on node0, importing the scriptPubKeys and | Test importmulti by generating keys on node0, importing the scriptPubKeys and | ||||
| addresses on node1 and then testing the address info for the different address | addresses on node1 and then testing the address info for the different address | ||||
| variants. | variants. | ||||
| - `get_key()` and `get_multisig()` are called to generate keys on node0 and | - `get_key()` and `get_multisig()` are called to generate keys on node0 and | ||||
| return the privkeys, pubkeys and all variants of scriptPubKey and address. | return the privkeys, pubkeys and all variants of scriptPubKey and address. | ||||
| - `test_importmulti()` is called to send an importmulti call to node1, test | - `test_importmulti()` is called to send an importmulti call to node1, test | ||||
| success, and (if unsuccessful) test the error code and error message returned. | success, and (if unsuccessful) test the error code and error message returned. | ||||
| - `test_address()` is called to call getaddressinfo for an address on node1 | - `test_address()` is called to call getaddressinfo for an address on node1 | ||||
| and test the values returned.""" | and test the values returned.""" | ||||
| from collections import namedtuple | |||||
| from test_framework.address import ( | |||||
| key_to_p2pkh, | |||||
| script_to_p2sh, | |||||
| ) | |||||
| from test_framework.script import ( | from test_framework.script import ( | ||||
| CScript, | CScript, | ||||
| OP_2, | |||||
| OP_3, | |||||
| OP_CHECKMULTISIG, | |||||
| OP_CHECKSIG, | |||||
| OP_DUP, | |||||
| OP_EQUAL, | |||||
| OP_EQUALVERIFY, | |||||
| OP_HASH160, | |||||
| OP_NOP, | OP_NOP, | ||||
| hash160, | |||||
| ) | ) | ||||
| from test_framework.test_framework import BitcoinTestFramework | from test_framework.test_framework import BitcoinTestFramework | ||||
| from test_framework.util import ( | from test_framework.util import ( | ||||
| assert_equal, | assert_equal, | ||||
| assert_greater_than, | assert_greater_than, | ||||
| assert_raises_rpc_error, | assert_raises_rpc_error, | ||||
| hex_str_to_bytes, | |||||
| ) | ) | ||||
| from test_framework.wallet_util import ( | |||||
| Key = namedtuple('Key', ['privkey', | get_key, | ||||
| 'pubkey', | get_multisig, | ||||
| 'p2pkh_script', | test_address, | ||||
| 'p2pkh_addr']) | ) | ||||
| Multisig = namedtuple('Multisig', ['privkeys', | |||||
| 'pubkeys', | |||||
| 'p2sh_script', | |||||
| 'p2sh_addr', | |||||
| 'redeem_script']) | |||||
| class ImportMultiTest(BitcoinTestFramework): | class ImportMultiTest(BitcoinTestFramework): | ||||
| def set_test_params(self): | def set_test_params(self): | ||||
| self.num_nodes = 2 | self.num_nodes = 2 | ||||
| self.setup_clean_chain = True | self.setup_clean_chain = True | ||||
| def skip_test_if_missing_module(self): | def skip_test_if_missing_module(self): | ||||
| self.skip_if_no_wallet() | self.skip_if_no_wallet() | ||||
| def setup_network(self, split=False): | def setup_network(self, split=False): | ||||
| self.setup_nodes() | self.setup_nodes() | ||||
| def get_key(self): | |||||
| """Generate a fresh key on node0 | |||||
| Returns a named tuple of privkey, pubkey and all address and scripts.""" | |||||
| addr = self.nodes[0].getnewaddress() | |||||
| pubkey = self.nodes[0].getaddressinfo(addr)['pubkey'] | |||||
| pkh = hash160(hex_str_to_bytes(pubkey)) | |||||
| return Key(privkey=self.nodes[0].dumpprivkey(addr), | |||||
| pubkey=pubkey, | |||||
| p2pkh_script=CScript( | |||||
| [OP_DUP, OP_HASH160, pkh, OP_EQUALVERIFY, OP_CHECKSIG]).hex(), | |||||
| p2pkh_addr=key_to_p2pkh(pubkey)) | |||||
| def get_multisig(self): | |||||
| """Generate a fresh 2-of-3 multisig on node0 | |||||
| Returns a named tuple of privkeys, pubkeys and all address and scripts.""" | |||||
| addrs = [] | |||||
| pubkeys = [] | |||||
| for _ in range(3): | |||||
| addr = self.nodes[0].getaddressinfo(self.nodes[0].getnewaddress()) | |||||
| addrs.append(addr['address']) | |||||
| pubkeys.append(addr['pubkey']) | |||||
| script_code = CScript([OP_2] + [hex_str_to_bytes(pubkey) | |||||
| for pubkey in pubkeys] + [OP_3, OP_CHECKMULTISIG]) | |||||
| return Multisig(privkeys=[self.nodes[0].dumpprivkey(addr) for addr in addrs], | |||||
| pubkeys=pubkeys, | |||||
| p2sh_script=CScript( | |||||
| [OP_HASH160, hash160(script_code), OP_EQUAL]).hex(), | |||||
| p2sh_addr=script_to_p2sh(script_code), | |||||
| redeem_script=script_code.hex()) | |||||
| def test_importmulti(self, req, success, error_code=None, | def test_importmulti(self, req, success, error_code=None, | ||||
| error_message=None, warnings=[]): | error_message=None, warnings=[]): | ||||
| """Run importmulti and assert success""" | """Run importmulti and assert success""" | ||||
| result = self.nodes[1].importmulti([req]) | result = self.nodes[1].importmulti([req]) | ||||
| observed_warnings = [] | observed_warnings = [] | ||||
| if 'warnings' in result[0]: | if 'warnings' in result[0]: | ||||
| observed_warnings = result[0]['warnings'] | observed_warnings = result[0]['warnings'] | ||||
| assert_equal( | assert_equal( | ||||
| "\n".join( | "\n".join( | ||||
| sorted(warnings)), "\n".join( | sorted(warnings)), "\n".join( | ||||
| sorted(observed_warnings))) | sorted(observed_warnings))) | ||||
| assert_equal(result[0]['success'], success) | assert_equal(result[0]['success'], success) | ||||
| if error_code is not None: | if error_code is not None: | ||||
| assert_equal(result[0]['error']['code'], error_code) | assert_equal(result[0]['error']['code'], error_code) | ||||
| assert_equal(result[0]['error']['message'], error_message) | assert_equal(result[0]['error']['message'], error_message) | ||||
| def test_address(self, address, **kwargs): | |||||
| """Get address info for `address` and test whether the returned values are as expected.""" | |||||
| addr_info = self.nodes[1].getaddressinfo(address) | |||||
| for key, value in kwargs.items(): | |||||
| if value is None: | |||||
| if key in addr_info.keys(): | |||||
| raise AssertionError( | |||||
| "key {} unexpectedly returned in getaddressinfo.".format(key)) | |||||
| elif addr_info[key] != value: | |||||
| raise AssertionError( | |||||
| "key {} value {} did not match expected value {}".format( | |||||
| key, addr_info[key], value)) | |||||
| def run_test(self): | def run_test(self): | ||||
| self.log.info("Mining blocks...") | self.log.info("Mining blocks...") | ||||
| self.nodes[0].generate(1) | self.nodes[0].generate(1) | ||||
| self.nodes[1].generate(1) | self.nodes[1].generate(1) | ||||
| timestamp = self.nodes[1].getblock( | timestamp = self.nodes[1].getblock( | ||||
| self.nodes[1].getbestblockhash())['mediantime'] | self.nodes[1].getbestblockhash())['mediantime'] | ||||
| node0_address1 = self.nodes[0].getaddressinfo( | node0_address1 = self.nodes[0].getaddressinfo( | ||||
| Show All 9 Lines | def run_test(self): | ||||
| address_info = self.nodes[1].getaddressinfo(node0_address1['address']) | address_info = self.nodes[1].getaddressinfo(node0_address1['address']) | ||||
| assert_equal(address_info['iswatchonly'], False) | assert_equal(address_info['iswatchonly'], False) | ||||
| assert_equal(address_info['ismine'], False) | assert_equal(address_info['ismine'], False) | ||||
| # RPC importmulti ----------------------------------------------- | # RPC importmulti ----------------------------------------------- | ||||
| # Bitcoin Address (implicit non-internal) | # Bitcoin Address (implicit non-internal) | ||||
| self.log.info("Should import an address") | self.log.info("Should import an address") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now"}, | "timestamp": "now"}, | ||||
| success=True) | success=True) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=timestamp, | timestamp=timestamp, | ||||
| ischange=False) | ischange=False) | ||||
| watchonly_address = key.p2pkh_addr | watchonly_address = key.p2pkh_addr | ||||
| watchonly_timestamp = timestamp | watchonly_timestamp = timestamp | ||||
| self.log.info("Should not import an invalid address") | self.log.info("Should not import an invalid address") | ||||
| self.test_importmulti({"scriptPubKey": {"address": "not valid address"}, | self.test_importmulti({"scriptPubKey": {"address": "not valid address"}, | ||||
| "timestamp": "now"}, | "timestamp": "now"}, | ||||
| success=False, | success=False, | ||||
| error_code=-5, | error_code=-5, | ||||
| error_message='Invalid address \"not valid address\"') | error_message='Invalid address \"not valid address\"') | ||||
| # ScriptPubKey + internal | # ScriptPubKey + internal | ||||
| self.log.info("Should import a scriptPubKey with internal flag") | self.log.info("Should import a scriptPubKey with internal flag") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": key.p2pkh_script, | self.test_importmulti({"scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "internal": True}, | "internal": True}, | ||||
| success=True) | success=True) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=timestamp, | timestamp=timestamp, | ||||
| ischange=True) | ischange=True) | ||||
| # ScriptPubKey + internal + label | # ScriptPubKey + internal + label | ||||
| self.log.info( | self.log.info( | ||||
| "Should not allow a label to be specified when internal is true") | "Should not allow a label to be specified when internal is true") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": key.p2pkh_script, | self.test_importmulti({"scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "internal": True, | "internal": True, | ||||
| "label": "Example label"}, | "label": "Example label"}, | ||||
| success=False, | success=False, | ||||
| error_code=-8, | error_code=-8, | ||||
| error_message='Internal addresses should not have a label') | error_message='Internal addresses should not have a label') | ||||
| # Nonstandard scriptPubKey + !internal | # Nonstandard scriptPubKey + !internal | ||||
| self.log.info( | self.log.info( | ||||
| "Should not import a nonstandard scriptPubKey without internal flag") | "Should not import a nonstandard scriptPubKey without internal flag") | ||||
| nonstandardScriptPubKey = key.p2pkh_script + CScript([OP_NOP]).hex() | nonstandardScriptPubKey = key.p2pkh_script + CScript([OP_NOP]).hex() | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": nonstandardScriptPubKey, | self.test_importmulti({"scriptPubKey": nonstandardScriptPubKey, | ||||
| "timestamp": "now"}, | "timestamp": "now"}, | ||||
| success=False, | success=False, | ||||
| error_code=-8, | error_code=-8, | ||||
| error_message='Internal must be set to true for nonstandard scriptPubKey imports.') | error_message='Internal must be set to true for nonstandard scriptPubKey imports.') | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=False, | iswatchonly=False, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=None) | timestamp=None) | ||||
| # Address + Public key + !Internal(explicit) | # Address + Public key + !Internal(explicit) | ||||
| self.log.info("Should import an address with public key") | self.log.info("Should import an address with public key") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "pubkeys": [key.pubkey], | "pubkeys": [key.pubkey], | ||||
| "internal": False}, | "internal": False}, | ||||
| success=True, | success=True, | ||||
| warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # ScriptPubKey + Public key + internal | # ScriptPubKey + Public key + internal | ||||
| self.log.info( | self.log.info( | ||||
| "Should import a scriptPubKey with internal and with public key") | "Should import a scriptPubKey with internal and with public key") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": key.p2pkh_script, | self.test_importmulti({"scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "pubkeys": [key.pubkey], | "pubkeys": [key.pubkey], | ||||
| "internal": True}, | "internal": True}, | ||||
| success=True, | success=True, | ||||
| warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # Nonstandard scriptPubKey + Public key + !internal | # Nonstandard scriptPubKey + Public key + !internal | ||||
| self.log.info( | self.log.info( | ||||
| "Should not import a nonstandard scriptPubKey without internal and with public key") | "Should not import a nonstandard scriptPubKey without internal and with public key") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": nonstandardScriptPubKey, | self.test_importmulti({"scriptPubKey": nonstandardScriptPubKey, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "pubkeys": [key.pubkey]}, | "pubkeys": [key.pubkey]}, | ||||
| success=False, | success=False, | ||||
| error_code=-8, | error_code=-8, | ||||
| error_message='Internal must be set to true for nonstandard scriptPubKey imports.') | error_message='Internal must be set to true for nonstandard scriptPubKey imports.') | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=False, | iswatchonly=False, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=None) | timestamp=None) | ||||
| # Address + Private key + !watchonly | # Address + Private key + !watchonly | ||||
| self.log.info("Should import an address with private key") | self.log.info("Should import an address with private key") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [key.privkey]}, | "keys": [key.privkey]}, | ||||
| success=True) | success=True) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=False, | iswatchonly=False, | ||||
| ismine=True, | ismine=True, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| self.log.info( | self.log.info( | ||||
| "Should not import an address with private key if is already imported") | "Should not import an address with private key if is already imported") | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [key.privkey]}, | "keys": [key.privkey]}, | ||||
| success=False, | success=False, | ||||
| error_code=-4, | error_code=-4, | ||||
| error_message='The wallet already contains the private key for this address or script') | error_message='The wallet already contains the private key for this address or script') | ||||
| # Address + Private key + watchonly | # Address + Private key + watchonly | ||||
| self.log.info( | self.log.info( | ||||
| "Should import an address with private key and with watchonly") | "Should import an address with private key and with watchonly") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [key.privkey], | "keys": [key.privkey], | ||||
| "watchonly": True}, | "watchonly": True}, | ||||
| success=True, | success=True, | ||||
| warnings=["All private keys are provided, outputs will be considered spendable. If this is intentional, do not specify the watchonly flag."]) | warnings=["All private keys are provided, outputs will be considered spendable. If this is intentional, do not specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=False, | iswatchonly=False, | ||||
| ismine=True, | ismine=True, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # ScriptPubKey + Private key + internal | # ScriptPubKey + Private key + internal | ||||
| self.log.info( | self.log.info( | ||||
| "Should import a scriptPubKey with internal and with private key") | "Should import a scriptPubKey with internal and with private key") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": key.p2pkh_script, | self.test_importmulti({"scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [key.privkey], | "keys": [key.privkey], | ||||
| "internal": True}, | "internal": True}, | ||||
| success=True) | success=True) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=False, | iswatchonly=False, | ||||
| ismine=True, | ismine=True, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # Nonstandard scriptPubKey + Private key + !internal | # Nonstandard scriptPubKey + Private key + !internal | ||||
| self.log.info( | self.log.info( | ||||
| "Should not import a nonstandard scriptPubKey without internal and with private key") | "Should not import a nonstandard scriptPubKey without internal and with private key") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| self.test_importmulti({"scriptPubKey": nonstandardScriptPubKey, | self.test_importmulti({"scriptPubKey": nonstandardScriptPubKey, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [key.privkey]}, | "keys": [key.privkey]}, | ||||
| success=False, | success=False, | ||||
| error_code=-8, | error_code=-8, | ||||
| error_message='Internal must be set to true for nonstandard scriptPubKey imports.') | error_message='Internal must be set to true for nonstandard scriptPubKey imports.') | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=False, | iswatchonly=False, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=None) | timestamp=None) | ||||
| # P2SH address | # P2SH address | ||||
| multisig = self.get_multisig() | multisig = get_multisig(self.nodes[0]) | ||||
| self.nodes[1].generate(100) | self.nodes[1].generate(100) | ||||
| self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | ||||
| self.nodes[1].generate(1) | self.nodes[1].generate(1) | ||||
| timestamp = self.nodes[1].getblock( | timestamp = self.nodes[1].getblock( | ||||
| self.nodes[1].getbestblockhash())['mediantime'] | self.nodes[1].getbestblockhash())['mediantime'] | ||||
| self.log.info("Should import a p2sh") | self.log.info("Should import a p2sh") | ||||
| self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | ||||
| "timestamp": "now"}, | "timestamp": "now"}, | ||||
| success=True) | success=True) | ||||
| self.test_address(multisig.p2sh_addr, | test_address(self.nodes[1], | ||||
| multisig.p2sh_addr, | |||||
| isscript=True, | isscript=True, | ||||
| iswatchonly=True, | iswatchonly=True, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| p2shunspent = self.nodes[1].listunspent( | p2shunspent = self.nodes[1].listunspent( | ||||
| 0, 999999, [multisig.p2sh_addr])[0] | 0, 999999, [multisig.p2sh_addr])[0] | ||||
| assert_equal(p2shunspent['spendable'], False) | assert_equal(p2shunspent['spendable'], False) | ||||
| assert_equal(p2shunspent['solvable'], False) | assert_equal(p2shunspent['solvable'], False) | ||||
| # P2SH + Redeem script | # P2SH + Redeem script | ||||
| multisig = self.get_multisig() | multisig = get_multisig(self.nodes[0]) | ||||
| self.nodes[1].generate(100) | self.nodes[1].generate(100) | ||||
| self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | ||||
| self.nodes[1].generate(1) | self.nodes[1].generate(1) | ||||
| timestamp = self.nodes[1].getblock( | timestamp = self.nodes[1].getblock( | ||||
| self.nodes[1].getbestblockhash())['mediantime'] | self.nodes[1].getbestblockhash())['mediantime'] | ||||
| self.log.info("Should import a p2sh with respective redeem script") | self.log.info("Should import a p2sh with respective redeem script") | ||||
| self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "redeemscript": multisig.redeem_script}, | "redeemscript": multisig.redeem_script}, | ||||
| success=True, | success=True, | ||||
| warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address( | test_address(self.nodes[1], | ||||
| multisig.p2sh_addr, | multisig.p2sh_addr, timestamp=timestamp, iswatchonly=True, ismine=False, solvable=True) | ||||
Fabien: Nit: keep the previous llayout | |||||
| timestamp=timestamp, | |||||
| iswatchonly=True, | |||||
| ismine=False, | |||||
| solvable=True) | |||||
| p2shunspent = self.nodes[1].listunspent( | p2shunspent = self.nodes[1].listunspent( | ||||
| 0, 999999, [multisig.p2sh_addr])[0] | 0, 999999, [multisig.p2sh_addr])[0] | ||||
| assert_equal(p2shunspent['spendable'], False) | assert_equal(p2shunspent['spendable'], False) | ||||
| assert_equal(p2shunspent['solvable'], True) | assert_equal(p2shunspent['solvable'], True) | ||||
| # P2SH + Redeem script + Private Keys + !Watchonly | # P2SH + Redeem script + Private Keys + !Watchonly | ||||
| multisig = self.get_multisig() | multisig = get_multisig(self.nodes[0]) | ||||
| self.nodes[1].generate(100) | self.nodes[1].generate(100) | ||||
| self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | ||||
| self.nodes[1].generate(1) | self.nodes[1].generate(1) | ||||
| timestamp = self.nodes[1].getblock( | timestamp = self.nodes[1].getblock( | ||||
| self.nodes[1].getbestblockhash())['mediantime'] | self.nodes[1].getbestblockhash())['mediantime'] | ||||
| self.log.info( | self.log.info( | ||||
| "Should import a p2sh with respective redeem script and private keys") | "Should import a p2sh with respective redeem script and private keys") | ||||
| self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "redeemscript": multisig.redeem_script, | "redeemscript": multisig.redeem_script, | ||||
| "keys": multisig.privkeys[0:2]}, | "keys": multisig.privkeys[0:2]}, | ||||
| success=True, | success=True, | ||||
| warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(multisig.p2sh_addr, | test_address(self.nodes[1], | ||||
| multisig.p2sh_addr, | |||||
| timestamp=timestamp, | timestamp=timestamp, | ||||
| ismine=False, | ismine=False, | ||||
| iswatchonly=True, | iswatchonly=True, | ||||
| solvable=True) | solvable=True) | ||||
| p2shunspent = self.nodes[1].listunspent( | p2shunspent = self.nodes[1].listunspent( | ||||
| 0, 999999, [multisig.p2sh_addr])[0] | 0, 999999, [multisig.p2sh_addr])[0] | ||||
| assert_equal(p2shunspent['spendable'], False) | assert_equal(p2shunspent['spendable'], False) | ||||
| assert_equal(p2shunspent['solvable'], True) | assert_equal(p2shunspent['solvable'], True) | ||||
| # P2SH + Redeem script + Private Keys + Watchonly | # P2SH + Redeem script + Private Keys + Watchonly | ||||
| multisig = self.get_multisig() | multisig = get_multisig(self.nodes[0]) | ||||
| self.nodes[1].generate(100) | self.nodes[1].generate(100) | ||||
| self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | self.nodes[1].sendtoaddress(multisig.p2sh_addr, 10.00) | ||||
| self.nodes[1].generate(1) | self.nodes[1].generate(1) | ||||
| timestamp = self.nodes[1].getblock( | timestamp = self.nodes[1].getblock( | ||||
| self.nodes[1].getbestblockhash())['mediantime'] | self.nodes[1].getbestblockhash())['mediantime'] | ||||
| self.log.info( | self.log.info( | ||||
| "Should import a p2sh with respective redeem script and private keys") | "Should import a p2sh with respective redeem script and private keys") | ||||
| self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | self.test_importmulti({"scriptPubKey": {"address": multisig.p2sh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "redeemscript": multisig.redeem_script, | "redeemscript": multisig.redeem_script, | ||||
| "keys": multisig.privkeys[0:2], | "keys": multisig.privkeys[0:2], | ||||
| "watchonly": True}, | "watchonly": True}, | ||||
| success=True) | success=True) | ||||
| self.test_address(multisig.p2sh_addr, | test_address(self.nodes[1], | ||||
| multisig.p2sh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| solvable=True, | solvable=True, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # Address + Public key + !Internal + Wrong pubkey | # Address + Public key + !Internal + Wrong pubkey | ||||
| self.log.info( | self.log.info( | ||||
| "Should not import an address with the wrong public key as non-solvable") | "Should not import an address with the wrong public key as non-solvable") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| wrong_key = self.get_key().pubkey | wrong_key = get_key(self.nodes[0]).pubkey | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "pubkeys": [wrong_key]}, | "pubkeys": [wrong_key]}, | ||||
| success=True, | success=True, | ||||
| warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| solvable=False, | solvable=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # ScriptPubKey + Public key + internal + Wrong pubkey | # ScriptPubKey + Public key + internal + Wrong pubkey | ||||
| self.log.info( | self.log.info( | ||||
| "Should import a scriptPubKey with internal and with a wrong public key as non-solvable") | "Should import a scriptPubKey with internal and with a wrong public key as non-solvable") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| wrong_key = self.get_key().pubkey | wrong_key = get_key(self.nodes[0]).pubkey | ||||
| self.test_importmulti({"scriptPubKey": key.p2pkh_script, | self.test_importmulti({"scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "pubkeys": [wrong_key], | "pubkeys": [wrong_key], | ||||
| "internal": True}, | "internal": True}, | ||||
| success=True, | success=True, | ||||
| warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| solvable=False, | solvable=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # Address + Private key + !watchonly + Wrong private key | # Address + Private key + !watchonly + Wrong private key | ||||
| self.log.info( | self.log.info( | ||||
| "Should import an address with a wrong private key as non-solvable") | "Should import an address with a wrong private key as non-solvable") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| wrong_privkey = self.get_key().privkey | wrong_privkey = get_key(self.nodes[0]).privkey | ||||
| self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | self.test_importmulti({"scriptPubKey": {"address": key.p2pkh_addr}, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [wrong_privkey]}, | "keys": [wrong_privkey]}, | ||||
| success=True, | success=True, | ||||
| warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| solvable=False, | solvable=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # ScriptPubKey + Private key + internal + Wrong private key | # ScriptPubKey + Private key + internal + Wrong private key | ||||
| self.log.info( | self.log.info( | ||||
| "Should import a scriptPubKey with internal and with a wrong private key as non-solvable") | "Should import a scriptPubKey with internal and with a wrong private key as non-solvable") | ||||
| key = self.get_key() | key = get_key(self.nodes[0]) | ||||
| wrong_privkey = self.get_key().privkey | wrong_privkey = get_key(self.nodes[0]).privkey | ||||
| self.test_importmulti({"scriptPubKey": key.p2pkh_script, | self.test_importmulti({"scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "now", | "timestamp": "now", | ||||
| "keys": [wrong_privkey], | "keys": [wrong_privkey], | ||||
| "internal": True}, | "internal": True}, | ||||
| success=True, | success=True, | ||||
| warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | warnings=["Importing as non-solvable: some required keys are missing. If this is intentional, don't provide any keys, pubkeys or redeemscript.", "Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."]) | ||||
| self.test_address(key.p2pkh_addr, | test_address(self.nodes[1], | ||||
| key.p2pkh_addr, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| solvable=False, | solvable=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| # Importing existing watch only address with new timestamp should | # Importing existing watch only address with new timestamp should | ||||
| # replace saved timestamp. | # replace saved timestamp. | ||||
| assert_greater_than(timestamp, watchonly_timestamp) | assert_greater_than(timestamp, watchonly_timestamp) | ||||
| self.log.info("Should replace previously saved watch only timestamp.") | self.log.info("Should replace previously saved watch only timestamp.") | ||||
| self.test_importmulti({"scriptPubKey": {"address": watchonly_address}, | self.test_importmulti({"scriptPubKey": {"address": watchonly_address}, | ||||
| "timestamp": "now"}, | "timestamp": "now"}, | ||||
| success=True) | success=True) | ||||
| self.test_address(watchonly_address, | test_address(self.nodes[1], | ||||
| watchonly_address, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=timestamp) | timestamp=timestamp) | ||||
| watchonly_timestamp = timestamp | watchonly_timestamp = timestamp | ||||
| # restart nodes to check for proper serialization/deserialization of | # restart nodes to check for proper serialization/deserialization of | ||||
| # watch only address | # watch only address | ||||
| self.stop_nodes() | self.stop_nodes() | ||||
| self.start_nodes() | self.start_nodes() | ||||
| self.test_address(watchonly_address, | test_address(self.nodes[1], | ||||
| watchonly_address, | |||||
| iswatchonly=True, | iswatchonly=True, | ||||
| ismine=False, | ismine=False, | ||||
| timestamp=watchonly_timestamp) | timestamp=watchonly_timestamp) | ||||
| # Bad or missing timestamps | # Bad or missing timestamps | ||||
| self.log.info("Should throw on invalid or missing timestamp values") | self.log.info("Should throw on invalid or missing timestamp values") | ||||
| assert_raises_rpc_error(-3, 'Missing required timestamp field for key', | assert_raises_rpc_error(-3, 'Missing required timestamp field for key', | ||||
| self.nodes[1].importmulti, [{"scriptPubKey": key.p2pkh_script}]) | self.nodes[1].importmulti, [{"scriptPubKey": key.p2pkh_script}]) | ||||
| assert_raises_rpc_error(-3, 'Expected number or "now" timestamp value for key. got type string', | assert_raises_rpc_error(-3, 'Expected number or "now" timestamp value for key. got type string', | ||||
| self.nodes[1].importmulti, [{ | self.nodes[1].importmulti, [{ | ||||
| "scriptPubKey": key.p2pkh_script, | "scriptPubKey": key.p2pkh_script, | ||||
| "timestamp": "" | "timestamp": "" | ||||
| }]) | }]) | ||||
| if __name__ == '__main__': | if __name__ == '__main__': | ||||
| ImportMultiTest().main() | ImportMultiTest().main() | ||||
Nit: keep the previous llayout