Page MenuHomePhabricator

[tests] move wallet util functions to wallet_util.py
ClosedPublic

Authored by deadalnix on Thu, May 21, 00:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3673616a27fb: [tests] move wallet util functions to wallet_util.py
Summary

Adds a new wallet_util.py module and moves generic helper functions
there:

  • get_key
  • get_multisig
  • test_address

This is a partial backport of Core PR15108 : https://github.com/bitcoin/bitcoin/pull/15108/commits/2d5f1ea2e3f9629d313f1d2aff94a15ef8e1128a

Depends on D6186 and D6185

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Thu, May 21, 00:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 21, 00:04
deadalnix requested review of this revision.Thu, May 21, 00:04
teamcity edited the summary of this revision. (Show Details)Thu, May 21, 00:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Thu, May 21, 12:30
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_importmulti.py
302 ↗(On Diff #20434)

Nit: keep the previous llayout

This revision is now accepted and ready to land.Thu, May 21, 12:30
deadalnix updated this revision to Diff 20445.Thu, May 21, 13:09

Fix formatting

This revision was landed with ongoing or failed builds.Thu, May 21, 13:10
This revision was automatically updated to reflect the committed changes.