Differential D6190

[wallet] Refactor ProcessImport() to call ProcessImportLegacy()
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 12:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7a9da1a4ffe8: [wallet] Refactor ProcessImport() to call ProcessImportLegacy()

Summary

This is almost entirely a move-only commit.

Reviewer hint: use --color-moved=zebra for review.

This is a partial backport of Core PR14491 : https://github.com/bitcoin/bitcoin/pull/14491/commits/d2b381cc91b2c4e74abe11e5bd66af647b70dafb

Depends on D6189

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 21 2020, 12:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 12:38

deadalnix requested review of this revision.May 21 2020, 12:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Fixup bad diff

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10930: Diff 20436.May 21 2020, 12:55

deadalnix added a child revision: D6191: [wallet] Allow descriptor imports with importmulti.May 21 2020, 12:56

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10931: Diff 20437.May 21 2020, 12:57

Fabien accepted this revision.May 21 2020, 13:02

This revision is now accepted and ready to land.May 21 2020, 13:02

Closed by commit rABC7a9da1a4ffe8: [wallet] Refactor ProcessImport() to call ProcessImportLegacy() (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 21 2020, 13:04

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7a9da1a4ffe8: [wallet] Refactor ProcessImport() to call ProcessImportLegacy().

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

348 lines

Diff 20443

View Options

[wallet] Refactor ProcessImport() to call ProcessImportLegacy()ClosedPublicActions