Page MenuHomePhabricator
Differential D6189

[wallet] Add ProcessImportLegacy()
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 12:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfeb47bc21f28: [wallet] Add ProcessImportLegacy()
Summary

This commit adds a ProcessImportLegacy() function which
currently does nothing. It also unindents a block of
code for a future move-only change.

Reviewer hint: review with -w to ignore whitespace changes.

This is a partial backport of Core PR14491 : https://github.com/bitcoin/bitcoin/pull/14491/commits/4cac0ddd258bc82258ccc99568d02d3b2415339d

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 21 2020, 12:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 12:20
deadalnix requested review of this revision.May 21 2020, 12:20
teamcity edited the summary of this revision. (Show Details)May 21 2020, 12:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 12:21

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 12:21

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 12:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 12:22

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 12:25

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 12:31

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10929: Diff 20435.May 21 2020, 12:31
deadalnix added a child revision: D6190: [wallet] Refactor ProcessImport() to call ProcessImportLegacy().May 21 2020, 12:38
Fabien accepted this revision.May 21 2020, 12:44
Fabien added a subscriber: Fabien.

Is the original commit just messing the indentation ?

This revision is now accepted and ready to land.May 21 2020, 12:44
Closed by commit rABCfeb47bc21f28: [wallet] Add ProcessImportLegacy() (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 21 2020, 13:03
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCfeb47bc21f28: [wallet] Add ProcessImportLegacy().

Revision Contents
Changeset List

PathSize
src/
wallet/
15 lines

Diff 20442

View Options

src/wallet/rpcdump.cpp

Loading...