Page MenuHomePhabricator

rpc: creates possibility to preserve labels on importprivkey
ClosedPublic

Authored by deadalnix on Wed, May 20, 23:26.

Details

Summary
  • changes importprivkey behavior to overwrite existent label if one

is passed and keep existing ones if no label is passed

  • tests behavior of importprivkey on existing address labels and

different same key destination

This is a backport of Core PR13381 .

I had to modify heavily the last test to create a P2SH manually. Bitcoin Core does produce a segwit wrapped into P2SH address by default so this isn't a problem for them.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, May 20, 23:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 20, 23:26
deadalnix requested review of this revision.Wed, May 20, 23:26
teamcity edited the summary of this revision. (Show Details)Wed, May 20, 23:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested changes to this revision.Wed, May 20, 23:51
majcosta added inline comments.
doc/release-notes-pr13381.md
29 ↗(On Diff #20404)

add to doc/release-notes.md and delete this one

This revision now requires changes to proceed.Wed, May 20, 23:51
majcosta added inline comments.Wed, May 20, 23:54
doc/release-notes-pr13381.md
29 ↗(On Diff #20404)

please

deadalnix updated this revision to Diff 20422.Thu, May 21, 00:45

Move release notes

majcosta accepted this revision.Thu, May 21, 00:52
This revision is now accepted and ready to land.Thu, May 21, 00:52
This revision was landed with ongoing or failed builds.Thu, May 21, 01:19
This revision was automatically updated to reflect the committed changes.