Page MenuHomePhabricator
Differential D6185

rpc: creates possibility to preserve labels on importprivkey
ClosedPublic
Actions

Authored by deadalnix on May 20 2020, 23:26.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCe9e95047acad: rpc: creates possibility to preserve labels on importprivkey
Summary
  • changes importprivkey behavior to overwrite existent label if one

is passed and keep existing ones if no label is passed

  • tests behavior of importprivkey on existing address labels and

different same key destination

This is a backport of Core PR13381 .

I had to modify heavily the last test to create a P2SH manually. Bitcoin Core does produce a segwit wrapped into P2SH address by default so this isn't a problem for them.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 20 2020, 23:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 23:26
deadalnix requested review of this revision.May 20 2020, 23:26
teamcity edited the summary of this revision. (Show Details)May 20 2020, 23:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 23:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 23:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 23:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 23:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

majcosta added a subscriber: majcosta.May 20 2020, 23:30
teamcity added a comment.May 20 2020, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 23:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10920: Diff 20404.May 20 2020, 23:40
majcosta requested changes to this revision.May 20 2020, 23:51
majcosta added inline comments.
doc/release-notes-pr13381.md
29 ↗(On Diff #20404)

add to doc/release-notes.md and delete this one

This revision now requires changes to proceed.May 20 2020, 23:51
majcosta added inline comments.May 20 2020, 23:54
doc/release-notes-pr13381.md
29 ↗(On Diff #20404)

please

deadalnix added a child revision: D6187: [tests] move wallet util functions to wallet_util.py.May 21 2020, 00:04
deadalnix updated this revision to Diff 20422.May 21 2020, 00:45

Move release notes

majcosta accepted this revision.May 21 2020, 00:52
This revision is now accepted and ready to land.May 21 2020, 00:52
teamcity added a comment.May 21 2020, 01:04

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 01:05

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 01:06

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 01:09

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

This revision was landed with ongoing or failed builds.May 21 2020, 01:19
Closed by commit rABCe9e95047acad: rpc: creates possibility to preserve labels on importprivkey (authored by marcoagner <marco@agner.io>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe9e95047acad: rpc: creates possibility to preserve labels on importprivkey.
teamcity added a comment.May 21 2020, 01:37

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 01:48

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10925: Diff 20422.May 21 2020, 01:48

Revision Contents
Changeset List

PathSize
doc/
30 lines
src/
wallet/
14 lines
test/
functional/
164 lines

Diff 20422

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/wallet_import_with_label.py

Loading...