Page MenuHomePhabricator
Differential D6186

[tests] tidy up wallet_importmulti.py
ClosedPublic
Actions

Authored by deadalnix on May 20 2020, 23:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC97962fdeaca1: [tests] tidy up wallet_importmulti.py
Summary

Fixes review comments from PR 14886.

This is a partial backport of Core PR15108 : https://github.com/bitcoin/bitcoin/pull/15108/commits/6be64ef02ca0832dfb74f74e5b026ead4cd7ef72

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 20 2020, 23:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 23:58
deadalnix requested review of this revision.May 20 2020, 23:58
teamcity edited the summary of this revision. (Show Details)May 20 2020, 23:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 23:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 23:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 23:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 00:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 00:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix added a child revision: D6187: [tests] move wallet util functions to wallet_util.py.May 21 2020, 00:04
teamcity added a comment.May 21 2020, 00:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10921: Diff 20405.May 21 2020, 00:09
deadalnix updated this revision to Diff 20433.May 21 2020, 11:44

rebase

teamcity added a comment.May 21 2020, 11:44

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 11:44

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 11:44

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 11:48

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 11:52

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 11:55

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10927: Diff 20433.May 21 2020, 11:55
Fabien accepted this revision.May 21 2020, 12:11
This revision is now accepted and ready to land.May 21 2020, 12:11
Closed by commit rABC97962fdeaca1: [tests] tidy up wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 21 2020, 13:04
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC97962fdeaca1: [tests] tidy up wallet_importmulti.py.

Revision Contents
Changeset List

PathSize
test/
functional/
128 lines

Diff 20444

View Options

test/functional/wallet_importmulti.py

Loading...