Page MenuHomePhabricator
Differential D6191

[wallet] Allow descriptor imports with importmulti
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 12:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc75e03625924: [wallet] Allow descriptor imports with importmulti
Summary

This is a partial backport of Core PR14491 : https://github.com/bitcoin/bitcoin/pull/14491/commits/9f48053d8f9a1feacc96d7e2a00c8a3a67576948

Depends on D6190

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 21 2020, 12:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 12:56
deadalnix requested review of this revision.May 21 2020, 12:56
teamcity edited the summary of this revision. (Show Details)May 21 2020, 12:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 12:57

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 12:57

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 12:57

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 13:00

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

deadalnix added a child revision: D6192: Add test for importing via descriptor.May 21 2020, 13:01
teamcity added a comment.May 21 2020, 13:01

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 13:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10932: Diff 20439.May 21 2020, 13:07
Fabien accepted this revision.May 21 2020, 14:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcdump.cpp
1625 ↗(On Diff #20439)

good catch

This revision is now accepted and ready to land.May 21 2020, 14:31
Closed by commit rABCc75e03625924: [wallet] Allow descriptor imports with importmulti (authored by MeshCollider <dobsonsa68@gmail.com>, committed by deadalnix). · Explain WhyMay 21 2020, 14:41
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc75e03625924: [wallet] Allow descriptor imports with importmulti.

Revision Contents
Changeset List

PathSize
src/
wallet/
189 lines
test/
functional/
2 lines

Diff 20453

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...