Page MenuHomePhabricator
Differential D6187

[tests] move wallet util functions to wallet_util.py
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 00:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3673616a27fb: [tests] move wallet util functions to wallet_util.py
Summary

Adds a new wallet_util.py module and moves generic helper functions
there:

  • get_key
  • get_multisig
  • test_address

This is a partial backport of Core PR15108 : https://github.com/bitcoin/bitcoin/pull/15108/commits/2d5f1ea2e3f9629d313f1d2aff94a15ef8e1128a

Depends on D6186 and D6185

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 21 2020, 00:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 00:04
deadalnix requested review of this revision.May 21 2020, 00:04
teamcity edited the summary of this revision. (Show Details)May 21 2020, 00:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 00:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 00:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 00:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 00:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 00:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 00:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10922: Diff 20406.May 21 2020, 00:19
deadalnix updated this revision to Diff 20434.May 21 2020, 11:49

rebase

teamcity added a comment.May 21 2020, 11:49

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 11:49

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 11:49

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 11:51

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 11:54

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 12:02

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10928: Diff 20434.May 21 2020, 12:02
Fabien accepted this revision.May 21 2020, 12:30
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_importmulti.py
302 ↗(On Diff #20434)

Nit: keep the previous llayout

This revision is now accepted and ready to land.May 21 2020, 12:30
deadalnix added a child revision: D6192: Add test for importing via descriptor.May 21 2020, 13:01
deadalnix updated this revision to Diff 20445.May 21 2020, 13:09

Fix formatting

This revision was landed with ongoing or failed builds.May 21 2020, 13:10
Closed by commit rABC3673616a27fb: [tests] move wallet util functions to wallet_util.py (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3673616a27fb: [tests] move wallet util functions to wallet_util.py.
teamcity added a comment.May 21 2020, 13:19

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 13:19

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 13:20

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 13:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 13:22

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 13:31

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10935: Diff 20445.May 21 2020, 13:31

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
83 lines
82 lines
317 lines

Diff 20406

View Options

test/functional/test_framework/wallet_util.py

Loading...
View Options

test/functional/wallet_import_with_label.py

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...