Page MenuHomePhabricator

add rule for better reviewing, don't amend new changes after diff accepted, new a diff for that.
ClosedPublic

Authored by andychen on Apr 9 2018, 15:28.

Details

Summary

amend changes to a accepted diff is dangerous, which will make the codebase out of control.

Test Plan

NA

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature/never_amend_after_diff_accepted
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2280
Build 2698: Bitcoin ABC Buildbot (legacy)
Build 2697: arc lint + arc unit