Differential D12064

[avalanche] Cleanup redundant proof count getters in PeerManager API
ClosedPublic
Actions

Authored by sdulfari on Sep 26 2022, 18:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdf44771070c0: [avalanche] Cleanup redundant proof count getters in PeerManager API

Summary

The pools can be accessed directly by the caller so there is no need for PeerManager to provide this API anymore.

Depends on D12062

Test Plan

ninja
./test/functional/test_runner.py abc_rpc_getavalancheinfo
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pm-api-cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20184
Build 40053: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40052: arc lint + arc unit

Event Timeline

sdulfari created this revision.Sep 26 2022, 18:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2022, 18:32

sdulfari requested review of this revision.Sep 26 2022, 18:32

Harbormaster completed remote builds in B20184: Diff 35195.Sep 26 2022, 18:54

Fabien accepted this revision.Sep 27 2022, 08:57

This revision is now accepted and ready to land.Sep 27 2022, 08:57

Closed by commit rABCdf44771070c0: [avalanche] Cleanup redundant proof count getters in PeerManager API (authored by sdulfari). · Explain WhySep 28 2022, 15:45

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABCdf44771070c0: [avalanche] Cleanup redundant proof count getters in PeerManager API.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

5 lines

rpc/

avalanche.cpp

10 lines

Diff 35195

View Options

src/avalanche/peermanager.h