Page MenuHomePhabricator

simplify ValidDeployment check to avoid gcc warning
ClosedPublic

Authored by sdulfari on Oct 17 2022, 20:36.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC214c0d52faa8: simplify ValidDeployment check to avoid gcc warning
Summary

Backport of core#22597

Simplifies the ValidDeployment check to only check the upperbound, relying on the lower bound to be trivially true due to enum values starting at the minimum value of the underlying type (which is checked at compile time in deploymentstatus.cpp). Avoids a "comparison always true" warning in some versions of gcc.

Our code differs from upstream. See D12220 and D3361 for details.

Test Plan

Check there are no more warnings during the build:

ninja

For sanity:

ninja check