Streamline contributor instructions for Rust stuff
Changes PlannedPublic
Actions

Authored by majcosta on Dec 14 2022, 18:12.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Get rid of extra steps and keep the toolchain used in a single file

Test Plan

Uninstall rustup (if installed)
Add a bunch of spaces before an fn main() in a .rs file
arc lint
Get told to install rustup
Install it
arc lint
Wait a while
Get an Auto-Fix followed by an OKAY

Diff Detail

Repository

rABC Bitcoin ABC

Branch

improve_rust_instructions

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21583
Build 42808: Build Diff
Build 42807: arc lint + arc unit

Event Timeline

majcosta created this revision.Dec 14 2022, 18:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2022, 18:12

majcosta requested review of this revision.Dec 14 2022, 18:12

Harbormaster completed remote builds in B21583: Diff 37301.Dec 14 2022, 18:12

one sec

use what rustup does, $HOME is more reliable than ~ anyway

Harbormaster completed remote builds in B21585: Diff 37303.Dec 14 2022, 19:10

rebase

Harbormaster completed remote builds in B21591: Diff 37310.Dec 14 2022, 19:50

majcosta planned changes to this revision.Dec 14 2022, 20:54

This doesn't really work, I can pin the correct nightly rustfmt to the project but no without also pinning the rest of the nightly toolchain, which isn't necessarily desirable. Just gotta wait for stable rustfmt to catch up in features.