Page MenuHomePhabricator
Differential D12944

[avalanche] Improve test coverage of existing parking behavior
ClosedPublic
Actions

Authored by sdulfari on Dec 29 2022, 21:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfc44fd909ab4: [avalanche] Improve test coverage of existing parking behavior
Summary

Generalize the test coverage of parking blocks near the chaintip so that we
check different chain lengths.

Depends on D12943

Test Plan
ninja
./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ava-finalize-test-chains
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21682
Build 43004: Build Diffbuild-debug · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 43003: arc lint + arc unit

Event Timeline

sdulfari created this revision.Dec 29 2022, 21:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 29 2022, 21:35
sdulfari requested review of this revision.Dec 29 2022, 21:35
Harbormaster completed remote builds in B21681: Diff 37440.Dec 29 2022, 21:51
Fabien requested changes to this revision.Dec 30 2022, 10:13
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_p2p_avalanche_voting.py
256 ↗(On Diff #37440)
280 ↗(On Diff #37440)

The flow is confusing. I suggest you extract the 1 block case then loop over the remaining with no special case so it's easy to understand what's going on

This revision now requires changes to proceed.Dec 30 2022, 10:13
sdulfari updated this revision to Diff 37443.Dec 31 2022, 19:12

Pull 1 block case out of the loop and other fixes from feedback

Harbormaster completed remote builds in B21682: Diff 37443.Dec 31 2022, 19:25
Fabien accepted this revision.Jan 1 2023, 14:46
This revision is now accepted and ready to land.Jan 1 2023, 14:46
Closed by commit rABCfc44fd909ab4: [avalanche] Improve test coverage of existing parking behavior (authored by sdulfari). · Explain WhyJan 1 2023, 23:31
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABCfc44fd909ab4: [avalanche] Improve test coverage of existing parking behavior.

Revision Contents
Changeset List

PathSize
test/
functional/
70 lines

Diff 37443

View Options

test/functional/abc_p2p_avalanche_voting.py

Loading...