[buildbot] Add links to bchn repo when porting code
ClosedPublic
Actions

Authored by Fabien on Feb 6 2023, 11:01.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC1938c579b1bc: [buildbot] Add links to bchn repo when porting code

Summary

Uses a similar syntax than core, core-gui and secp256k1 with prefix bchn.

Test Plan

ninja check-buildbot

Diff Detail

Repository

rABC Bitcoin ABC

Branch

buildbot_bchn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21941
Build 43517: Build Diff	check-buildbot
Build 43516: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 6 2023, 11:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2023, 11:01

Fabien requested review of this revision.Feb 6 2023, 11:01

Harbormaster completed remote builds in B21940: Diff 37824.Feb 6 2023, 11:02

Fabien retitled this revision from [buildbot] Add links to bchn repo when backporting to [buildbot] Add links to bchn repo when porting code.Feb 6 2023, 18:40

backport => port

Harbormaster completed remote builds in B21941: Diff 37825.Feb 6 2023, 18:42

sdulfari accepted this revision.Feb 6 2023, 19:11

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

contrib/buildbot/test/test_endpoint_backportcheck.py
148	I do not know what the significance of the `/-` is but the URL you provide in the test does a redirect. Consider adding the dash in if you can figure out what it is for.

This revision is now accepted and ready to land.Feb 6 2023, 19:11

Fabien added inline comments.Feb 6 2023, 19:13

contrib/buildbot/test/test_endpoint_backportcheck.py
148	I noticed it but I don't know if it exists the same for all gitlab repos so I decided to not include it. The natural URL is hopefully more robust despite the redirect.