Page MenuHomePhabricator
Differential D13150

[avalanche] Add regression testing for flip flopping votes on blocks
ClosedPublic
Actions

Authored by sdulfari on Feb 21 2023, 20:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd883fe1178d4: [avalanche] Add regression testing for flip flopping votes on blocks
Summary

As we introduce new behavior (block policies) that could impact block parking
we need to ensure that flip flopping avalanche votes behave as expected and do
not regress.

Depends on D13149

I also took this opportunity to make the log checking more consistent for the
first acceptance.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ava-tip-extra-coverage
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22045
Build 43725: Build Diffbuild-without-wallet · build-clang-tidy · build-diff · build-debug · build-clang
Build 43724: arc lint + arc unit

Event Timeline

sdulfari created this revision.Feb 21 2023, 20:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2023, 20:14
sdulfari requested review of this revision.Feb 21 2023, 20:14
Harbormaster completed remote builds in B22043: Diff 37969.Feb 21 2023, 20:26
Fabien accepted this revision.Feb 21 2023, 21:16
Fabien added a subscriber: Fabien.

This change is OK but please fix the dependency and rebase to remove the super confusing wait_until calls

test/functional/abc_p2p_avalanche_voting.py
237 ↗(On Diff #37969)

See comment on D13149

241 ↗(On Diff #37969)

Dito

This revision is now accepted and ready to land.Feb 21 2023, 21:16
sdulfari updated this revision to Diff 37971.Feb 21 2023, 21:41

Rebase & fixup according to feedback

Harbormaster completed remote builds in B22045: Diff 37971.Feb 21 2023, 21:54
sdulfari added a child revision: D13118: [consensus + avalanche] Move miner fund from consensus to policy.Feb 21 2023, 21:56
Closed by commit rABCd883fe1178d4: [avalanche] Add regression testing for flip flopping votes on blocks (authored by sdulfari). · Explain WhyFeb 22 2023, 16:27
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABCd883fe1178d4: [avalanche] Add regression testing for flip flopping votes on blocks.

Revision Contents
Changeset List

PathSize
test/
functional/
12 lines

Diff 37971

View Options

test/functional/abc_p2p_avalanche_voting.py

Loading...