Differential D13743

[lint] Fix variables shadowing python builtins in the test framework
ClosedPublic
Actions

Authored by sdulfari on Apr 19 2023, 18:25.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4bf9ae763bf5: [lint] Fix variables shadowing python builtins in the test framework

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

ninja check-functional
flake8 test_framework/ | grep A001  # empty

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-test-framework

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23373
Build 46365: Build Diff	build-clang-tidy · build-diff · build-without-wallet · build-clang · build-debug
Build 46364: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 19 2023, 18:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2023, 18:25

sdulfari requested review of this revision.Apr 19 2023, 18:25

Harbormaster completed remote builds in B23373: Diff 39814.Apr 19 2023, 18:41

PiRK accepted this revision.Apr 19 2023, 19:17

This revision is now accepted and ready to land.Apr 19 2023, 19:17

Closed by commit rABC4bf9ae763bf5: [lint] Fix variables shadowing python builtins in the test framework (authored by sdulfari). · Explain WhyApr 19 2023, 20:17

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC4bf9ae763bf5: [lint] Fix variables shadowing python builtins in the test framework.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

netutil.py

8 lines

script.py

6 lines

Diff 39814

View Options

test/functional/test_framework/netutil.py