Adding the first section for the wealth redfined page. Most of the sub pages of the site have the same format for their top section
So I made a component that takes the animated image and text content for it, so we can reuse throughout
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC666eb0eb4c7e: [e.cash] Sub-page hero section
@bot preview-e.cash
navigate to the wealth-redefined page and check the top section looks good on mobile, desktop, and both themes
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-core-tech
- Lint
Lint Warnings Severity Location Code Message Warning web/e.cash/public/animations/spiningcoin.json:31 SPELL2 Possible Spelling Mistake Warning web/e.cash/public/animations/spiningcoin.json:47 SPELL2 Possible Spelling Mistake Warning web/e.cash/public/animations/spiningcoin.json:175 SPELL2 Possible Spelling Mistake - Unit
No Test Coverage - Build Status
Buildable 23748 Build 47106: Build Diff Build 47105: arc lint + arc unit
Event Timeline
Comment Actions
hmm will look into that lint error...its not a spelling mistake, there just happens to be some trigger characters in the data png
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41869 for the next 60 minutes.
Comment Actions
Is there a way around this lint issue? I cant just delete those letters from the encoding, and afaik the lint issue is not actually an issue with this file
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41237 for the next 60 minutes.
| web/e.cash/components/animate-image/index.js | ||
|---|---|---|
| 7 ↗ | (On Diff #40361) | seems like this should be a theme prop? Should at least define it as a constant in this component so we know what it is / why it is 0.4, e.g. const LOTTIE_ANIMATION_SPEED=0.4 // lottie rendering in s, matching webflow |
Comment Actions
cutoff at 320px
... annoying one, probably want to add a width rule to change the text from "Introduction" to "Intro" at this resolution
Looking at current prod site, seems like we currently have some kind of font size rule at that resolution:
Comment Actions
@bot preview-e.cash
| web/e.cash/components/animate-image/index.js | ||
|---|---|---|
| 5–6 | no blocker -- but FYI if you are using vscode here, try typing /** and then press enter, good way to set up longer comments | |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41577 for the next 60 minutes.