Page MenuHomePhabricator
Differential D14280

[e.cash] Remove theme switch
ClosedPublic
Actions

Authored by johnkuney on Jul 18 2023, 18:06.

Details

Reviewers
Mengerian
Group Reviewers
Restricted Project
Commits
rABC55b104d7a9e3: [e.cash] Remove theme switch
Summary

Will be no need for the theme switch in prod, and need to make room for language switcher
Removing it here and setting theme to stealth

Test Plan

preview the site and see if all looks right

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-remove-theme-toggle
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24538
Build 48675: Build Diff
Build 48674: arc lint + arc unit

Event Timeline

johnkuney created this revision.Jul 18 2023, 18:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2023, 18:06
johnkuney requested review of this revision.Jul 18 2023, 18:06
Harbormaster completed remote builds in B24536: Diff 41500.Jul 18 2023, 18:06
Mengerian requested changes to this revision.Jul 18 2023, 18:50
Mengerian added a subscriber: Mengerian.

I think we should launch the new site in normal "ecash" theme at first, then switch to Stealth mode after. Just so we are dealing with one variable at a time.

web/e.cash/pages/_app.js
10 ↗(On Diff #41500)

Let's set the theme to "ecash" to start

This revision now requires changes to proceed.Jul 18 2023, 18:50
johnkuney updated this revision to Diff 41502.Jul 18 2023, 19:25

make it ecash theme

Harbormaster completed remote builds in B24538: Diff 41502.Jul 18 2023, 19:25
Mengerian added a comment.Jul 18 2023, 20:18

@bot preview-e.cash

teamcity awarded a token.Jul 18 2023, 20:18

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41728 for the next 60 minutes.

Mengerian accepted this revision.Jul 18 2023, 20:21
This revision is now accepted and ready to land.Jul 18 2023, 20:21
Closed by commit rABC55b104d7a9e3: [e.cash] Remove theme switch (authored by johnkuney). · Explain WhyJul 18 2023, 20:32
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABC55b104d7a9e3: [e.cash] Remove theme switch.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
13 lines

Diff 41502

View Options

web/e.cash/pages/_app.js

Loading...