Differential D14580

[e.cash] Add Swapzone widget
ClosedPublic
Actions

Authored by johnkuney on Oct 2 2023, 22:25.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf37850abe9a7: [e.cash] Add Swapzone widget

Summary

Adding the Swapzone widget to the /get-ecash page

Test Plan

Preview the site and navigate to /get-ecash. check below the exchange listings for the swapzone widget. Check everything
looks good and functions properly

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-add-swapzone

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25237
Build 50060: Build Diff
Build 50059: arc lint + arc unit

Event Timeline

johnkuney created this revision.Oct 2 2023, 22:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 22:25

johnkuney requested review of this revision.Oct 2 2023, 22:25

Harbormaster completed remote builds in B25237: Diff 42497.Oct 2 2023, 22:25

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41089 for the next 60 minutes.

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41060 for the next 60 minutes.

tested with 1 buy and 1 sell. both work. Sell went through after 1 conf.

Potential issue if a user exits the widget before a trade completes. We might have to provide some level of support. But, neat feature, imo worth it.

This revision is now accepted and ready to land.Oct 3 2023, 04:08

Closed by commit rABCf37850abe9a7: [e.cash] Add Swapzone widget (authored by johnkuney). · Explain WhyOct 3 2023, 14:52

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCf37850abe9a7: [e.cash] Add Swapzone widget.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

get-ecash.js

22 lines

styles/

pages/

get-ecash.js

14 lines

Diff 42497

View Options

web/e.cash/pages/get-ecash.js