Differential D14632

[e.cash] Add weglot exclusion classname
ClosedPublic
Actions

Authored by johnkuney on Oct 12 2023, 03:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5d87c1bebe88: [e.cash] Add weglot exclusion classname

Summary

The translator is messing with the countdown numbers. Need to add this classname so I can tell weglot to ignore this block

Test Plan

nothing should change here. The countdown should behave better on the live site when you change the language though

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-add-weglot-class

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25338
Build 50257: Build Diff
Build 50256: arc lint + arc unit

Event Timeline

johnkuney created this revision.Oct 12 2023, 03:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2023, 03:51

johnkuney requested review of this revision.Oct 12 2023, 03:51

Harbormaster completed remote builds in B25338: Diff 42651.Oct 12 2023, 03:51

I suppose this class name is configured as well in the weglot backend to be ignored ? Then you should really give it a better and more obvious name (eg. weglot-ignore) + add some comment explaining that it's not a built-in feature but you have to configure it on the weglot side to make it work.

This revision now requires changes to proceed.Oct 12 2023, 08:15

change classname, add comment

Harbormaster completed remote builds in B25341: Diff 42655.Oct 12 2023, 16:20

Fabien accepted this revision.Oct 12 2023, 17:11

This revision is now accepted and ready to land.Oct 12 2023, 17:11

Closed by commit rABC5d87c1bebe88: [e.cash] Add weglot exclusion classname (authored by johnkuney). · Explain WhyOct 12 2023, 19:15

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC5d87c1bebe88: [e.cash] Add weglot exclusion classname.