Differential D14699

[e.cash] Open external links in new tab - mining page
ClosedPublic
Actions

Authored by johnkuney on Oct 29 2023, 22:48.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC3cb4ad246ac7: [e.cash] Open external links in new tab - mining page

Summary

Using the cusotm link component on the mining page so external links open in a new tab

Test Plan

Preview the site and check the links open in a new tab on the mining page

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-links-mining

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25470
Build 50521: Build Diff
Build 50520: arc lint + arc unit

Event Timeline

johnkuney created this revision.Oct 29 2023, 22:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2023, 22:48

johnkuney requested review of this revision.Oct 29 2023, 22:48

Harbormaster completed remote builds in B25470: Diff 42849.Oct 29 2023, 22:48

@bot preview-e.cash

teamcity awarded a token.Oct 30 2023, 17:01

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.62:41611 for the next 60 minutes.

bytesofman accepted this revision.Oct 30 2023, 17:17

This revision is now accepted and ready to land.Oct 30 2023, 17:17

Closed by commit rABC3cb4ad246ac7: [e.cash] Open external links in new tab - mining page (authored by johnkuney). · Explain WhyOct 30 2023, 21:29

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC3cb4ad246ac7: [e.cash] Open external links in new tab - mining page.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

mining.js

32 lines

Diff 42849

View Options

web/e.cash/pages/mining.js

[e.cash] Open external links in new tab - mining pageClosedPublicActions