Page MenuHomePhabricator
Differential D15223

[paybutton spec] Updates to spec
ClosedPublic
Actions

Authored by bytesofman on Jan 20 2024, 15:34.

Details

Reviewers
Klakurka
Group Reviewers
Restricted Project
Commits
rABCdb058e9c530c: [paybutton spec] Updates to spec
Summary
  • Specify data pushes will be utf8 encoded
  • Specify that all pushes are required. OP_0 may be pushed in the data or nonce position to signify these pushes are empty.

Ref https://github.com/PayButton/paybutton/pull/340

Test Plan

Confirm spec is accurate + desirable

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-paybutton-spec-improvements
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26517
Build 52604: Build Diff
Build 52603: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 20 2024, 15:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2024, 15:34
Harbormaster completed remote builds in B26517: Diff 44399.Jan 20 2024, 15:35
bytesofman published this revision for review.Jan 20 2024, 15:35
Klakurka requested changes to this revision.Jan 21 2024, 00:58
Klakurka added a subscriber: Klakurka.

We're using 12-byte examples for the nonce (payment ID) here but we're actually going to be doing 8 bytes so let's change that. The rest looks good.

This revision now requires changes to proceed.Jan 21 2024, 00:58
bytesofman updated this revision to Diff 44418.Jan 22 2024, 12:03

specify nonce at 8 bytes, change data example to 12 bytes to avoid confusion with nonce

Harbormaster completed remote builds in B26530: Diff 44418.Jan 22 2024, 12:04
bytesofman updated this revision to Diff 44449.Jan 22 2024, 17:56

Update spec to require all pushes

Harbormaster completed remote builds in B26555: Diff 44449.Jan 22 2024, 17:57
bytesofman retitled this revision from [paybutton spec] Specify pushes to be utf8 encoded to [paybutton spec] Updates to spec.Jan 22 2024, 17:57
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
Klakurka accepted this revision.Jan 23 2024, 00:57
This revision is now accepted and ready to land.Jan 23 2024, 00:57
Closed by commit rABCdb058e9c530c: [paybutton spec] Updates to spec (authored by bytesofman). · Explain WhyJan 23 2024, 01:02
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCdb058e9c530c: [paybutton spec] Updates to spec.

Revision Contents
Changeset List

PathSize
doc/
standards/
8 lines

Diff 44399

View Options

doc/standards/paybutton.md

Loading...