Page MenuHomePhabricator
Differential D15237

[e.cash] Wallets page design update
ClosedPublic
Actions

Authored by johnkuney on Jan 22 2024, 18:29.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCd732dc496fb9: [e.cash] Wallets page design update
Summary

Updates to the wallets page design to make it easier to consume, and make device compatiblity and features of
each wallet more clear

Test Plan

preview the site and check out /wallets. Does it look better? Open to design feedback

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-wallets-edits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26556
Build 52682: Build Diff
Build 52681: arc lint + arc unit

Event Timeline

johnkuney created this revision.Jan 22 2024, 18:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2024, 18:29
johnkuney requested review of this revision.Jan 22 2024, 18:29
Harbormaster completed remote builds in B26556: Diff 44450.Jan 22 2024, 18:29
bytesofman added a subscriber: bytesofman.Jan 22 2024, 19:59

@bot preview-e.cash

teamcity awarded a token.Jan 22 2024, 19:59

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41110 for the next 60 minutes.

bytesofman requested changes to this revision.Jan 22 2024, 20:11

imo definitely an improvement. could prob bump the css break points up a bit for the "3 to 2" and "2 to 1" column shift. They start getting pretty tall and skinny

image.png (660×820 px, 114 KB)

image.png (835×820 px, 101 KB)

This revision now requires changes to proceed.Jan 22 2024, 20:11
johnkuney updated this revision to Diff 44455.Jan 22 2024, 20:26

increase breakpoints

Harbormaster completed remote builds in B26560: Diff 44455.Jan 22 2024, 20:26
johnkuney added a comment.Jan 22 2024, 20:27

Yeah I agree, added

bytesofman added a comment.Jan 22 2024, 20:47

@bot preview-e.cash

teamcity updated a token.Jan 22 2024, 20:47

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41903 for the next 60 minutes.

bytesofman accepted this revision.Jan 22 2024, 20:54
This revision is now accepted and ready to land.Jan 22 2024, 20:54
Closed by commit rABCd732dc496fb9: [e.cash] Wallets page design update (authored by johnkuney). · Explain WhyJan 22 2024, 22:17
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABCd732dc496fb9: [e.cash] Wallets page design update.

Revision Contents
Changeset List

PathSize
web/
e.cash/
data/
17 lines
pages/
79 lines
public/
images/
styles/
pages/
156 lines

Diff 44450

View Options

web/e.cash/data/wallets.js

Loading...
View Options

web/e.cash/pages/wallets.js

Loading...
View Options

web/e.cash/public/images/abc-pay.png

Loading...
View Options

web/e.cash/public/images/unstoppable-wallet.png

Loading...
View Options

web/e.cash/styles/pages/wallets.js

Loading...