Make max tx input script sig size 1650 a constant.
ClosedPublic
Actions

Authored by andychen on Aug 13 2018, 12:15.

Details

Reviewers

Group Reviewers

Restricted Project
Restricted Owners Package	(Owns No Changed Paths)

Commits

rSTAGINGfa4f944a8c3a: Make max tx input script sig size 1650 a constant.
rABCfa4f944a8c3a: Make max tx input script sig size 1650 a constant.

Summary

Lot of comments for it in .cpp file, make it constant would be better.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature/make_txin_sig_max_size_constant

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3068
Build 4224: Bitcoin ABC Buildbot (legacy)
Build 4223: arc lint + arc unit

Event Timeline

andychen created this revision.Aug 13 2018, 12:15

Owners added a reviewer: Restricted Owners Package.Aug 13 2018, 12:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3068: Diff 4568.Aug 13 2018, 12:55

jasonbcox accepted this revision.Aug 13 2018, 14:41

This revision is now accepted and ready to land.Aug 13 2018, 14:41

Closed by commit rABCfa4f944a8c3a: Make max tx input script sig size 1650 a constant. (authored by andychen). · Explain WhyAug 14 2018, 02:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

policy/

policy.h

11 lines

policy.cpp

8 lines

Diff 4568

View Options

src/policy/policy.h