Differential D15745

[e.cash] Mobile nav menu improvments
ClosedPublic
Actions

Authored by johnkuney on Mar 20 2024, 17:05.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC5df76d261646: [e.cash] Mobile nav menu improvments

Summary

Adding the social links to the mobile nav and fixing a couple issues
-allow scrolling if content is taller than the screen
-add dropdown indicators to dropdown items

Test Plan

Preview the site and check the mobile menu. Test the social links and see if any issues

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-social-links-to-nav

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27956
Build 55462: Build Diff
Build 55461: arc lint + arc unit

Event Timeline

johnkuney created this revision.Mar 20 2024, 17:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 20 2024, 17:05

johnkuney requested review of this revision.Mar 20 2024, 17:05

Harbormaster completed remote builds in B27956: Diff 46329.Mar 20 2024, 17:05

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41163 for the next 60 minutes.

bytesofman accepted this revision.Mar 20 2024, 17:36

This revision is now accepted and ready to land.Mar 20 2024, 17:36

Closed by commit rABC5df76d261646: [e.cash] Mobile nav menu improvments (authored by johnkuney). · Explain WhyMar 20 2024, 18:36

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC5df76d261646: [e.cash] Mobile nav menu improvments.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

navbar/

index.js

29 lines

styles.js

43 lines

Diff 46329

View Options

web/e.cash/components/navbar/index.js