Page MenuHomePhabricator

[Cashtab] Stop using hash router for the webapp
AbandonedPublicDraft

Authored by bytesofman on Apr 19 2024, 22:16.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Hashrouter is not recommended for web applications. It is also kind of tacky to always have a '#' in the URL. Stop using it for the webapp.

The extension will not work with BrowserRouter since it is navigating files. Continue to use hash router for the extension (since the user typically does not actually see the URL for the extension).

Test Plan

npm test, TBD for extension

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-no-hash-router
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28679
Build 56899: Build Diffcashtab-tests
Build 56898: arc lint + arc unit

Event Timeline

really only reason to do this is aesthetics. the extension needs it so just keep it for now.