The eToken image on /core-tech was too large and all of the images have the same height.
Adding an optional height prop so we can adjust as needed
Details
- Reviewers
Kronkmeister - Group Reviewers
Restricted Project - Commits
- rABC5aaf45afad05: [e.cash] Adjust image height on core-tech
preview the site and check /core-tech. See all the images look good
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-image-size-adjustment
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29000 Build 57537: Build Diff Build 57536: arc lint + arc unit
Event Timeline
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41317 for the next 60 minutes.
When manually adjusting the window size, reducing it from fullscreen, the spinningcoin animation gets excessively large. While other images also resize, they don't grow as much. Any way to fix that?
Images below for comparison:
This is how large the hand gets:
this is the max size other animations get:
Probably because all the other animations are wide or square, while the spinninigcoin one has a relatively small width.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41082 for the next 60 minutes.
good to go. images behave a bit differently based on source file. but we plan on swapping out images, so might just fix this at a later date. for now the sizes are not too far off.