Page MenuHomePhabricator

[ecash] Add custom 404 page
ClosedPublic

Authored by johnkuney on Jun 19 2024, 17:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbbdc948f2706: [ecash] Add custom 404 page
Summary

Currently we just have the generic next.js 404 page
Adding a custom one with more pizzazz and next steps for the user

Test Plan

preview the site and go to the page that doesnt exist
should see the custom 404 page

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-404-page
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29352
Build 58240: Build Diff
Build 58239: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jun 19 2024, 21:07
Fabien added a subscriber: Fabien.

Please fix the linter issue

This revision now requires changes to proceed.Jun 19 2024, 21:07

Tail of the build log:

#4 sha256:650301efc6ecb22f7aa2e6978a125dfd602bc7b8444c6a496a19f69cc972ea7e
#4 CACHED

#6 [2/5] COPY . .
#6 sha256:c877c8f1e0817349d0267bbc14bb9f409e2839d01bfa0ce6480f6fb6c5304498
#6 DONE 0.4s

#7 [3/5] COPY next.preview.js next.config.js
#7 sha256:555db284ea8f9041d40659b63d3a6cb6f7ae07824f3cd391863468e63f93428a
#7 DONE 0.1s

#8 [4/5] RUN npm ci
#8 sha256:34584307ae2907d81ac514eaf05ee5ab4bf30455a9d75543d4d94ac05edcd4da
#8 10.91 
#8 10.91 added 819 packages, and audited 820 packages in 10s
#8 10.91 
#8 10.91 154 packages are looking for funding
#8 10.91   run `npm fund` for details
#8 10.94 
#8 10.94 3 high severity vulnerabilities
#8 10.94 
#8 10.94 To address issues that do not require attention, run:
#8 10.94   npm audit fix
#8 10.94 
#8 10.94 To address all issues, run:
#8 10.94   npm audit fix --force
#8 10.94 
#8 10.94 Run `npm audit` for details.
#8 10.94 npm notice 
#8 10.94 npm notice New major version of npm available! 8.19.4 -> 10.8.1
#8 10.94 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.1>
#8 10.94 npm notice Run `npm install -g npm@10.8.1` to update!
#8 10.94 npm notice 
#8 DONE 12.0s

#9 [5/5] RUN npm run build
#9 sha256:585f894781823c7c9cdc1a446753ec1e4c3311c877b61c903e2dce7c8063d4ad
#9 0.925 
#9 0.925 > e.cash@0.0.1 build
#9 0.925 > next build
#9 0.925 
#9 1.466 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#9 1.466 This information is used to shape Next.js' roadmap and prioritize features.
#9 1.466 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#9 1.466 https://nextjs.org/telemetry
#9 1.466 
#9 1.557    Linting and checking validity of types ...
#9 3.247 
#9 3.247 Failed to compile.
#9 3.247 
#9 3.247 ./pages/404.js
#9 3.247 18:36  Error: `'` can be escaped with `&apos;`, `&lsquo;`, `&#39;`, `&rsquo;`.  react/no-unescaped-entities
#9 3.247 
#9 3.247 info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
#9 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1
------
 > [5/5] RUN npm run build:
------
executor failed running [/bin/sh -c npm run build]: exit code: 1
Build preview-e.cash failed with exit code 1

ah yeah missed that thanks, fixed

This revision is now accepted and ready to land.Jun 20 2024, 07:30
This revision was automatically updated to reflect the committed changes.