Page MenuHomePhabricator
Differential D16628

[explorer] Update datatables packages
ClosedPublic
Actions

Authored by bytesofman on Aug 12 2024, 19:41.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABCb7dcfc4183ac: [explorer] Update datatables packages
Summary

Seeing an annoying error (sometimes) on page load, from datatables.

datatables is a cdn-delivered package. The version being used in explorer is pretty old.

Use the latest version.

ref: https://cdn.datatables.net/

Test Plan

cargo run and stuff seems to still work

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer-ajax-error
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29947
Build 59429: Build Diff
Build 59428: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 12 2024, 19:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2024, 19:41
Harbormaster completed remote builds in B29946: Diff 49158.Aug 12 2024, 19:41
bytesofman published this revision for review.Aug 12 2024, 19:41
bytesofman edited the summary of this revision. (Show Details)
bytesofman added a comment.EditedAug 12 2024, 19:47

some style differences in testing

this diff: update: resolved

image.png (173×199 px, 26 KB)

prod now:

image.png (173×232 px, 26 KB)

this diff [to be fixed]: update: resolved

image.png (220×1 px, 60 KB)

prod now:

image.png (220×1 px, 60 KB)

bytesofman planned changes to this revision.Aug 12 2024, 19:58

some css tweaks to fix described issues

bytesofman updated this revision to Diff 49159.Aug 12 2024, 20:15

css tweaks to match existing functionality and look

Harbormaster completed remote builds in B29947: Diff 49159.Aug 12 2024, 20:15
roqqit accepted this revision.Aug 12 2024, 21:03
This revision is now accepted and ready to land.Aug 12 2024, 21:03
Closed by commit rABCb7dcfc4183ac: [explorer] Update datatables packages (authored by bytesofman). · Explain WhyAug 12 2024, 21:08
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCb7dcfc4183ac: [explorer] Update datatables packages.

Revision Contents
Changeset List

PathSize
web/
explorer/
explorer-server/
code/
styles/
18 lines
templates/
16 lines

Diff 49159

View Options

web/explorer/explorer-server/code/styles/index.css

Loading...
View Options

web/explorer/explorer-server/templates/base.html

Loading...