Differential D16672

[explorer] Remove extra pagination
ClosedPublic
Actions

Authored by johnkuney on Aug 21 2024, 19:21.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9e12b2825253: [explorer] Remove extra pagination

Summary

All the tables have some extra, non-functioning pagination numbers showing at the bottom.
Happened with the datatables version update it seems like, the newer version defaults to showing pagination
but since we are using a custom solution here, need to hide it

Test Plan

preview the site and check those extra pagination numbers arent showing above the actual pagination

Diff Detail

Repository

rABC Bitcoin ABC

Branch

explorerhidenumbers

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30053
Build 59640: Build Diff
Build 59639: arc lint + arc unit

Event Timeline

johnkuney created this revision.Aug 21 2024, 19:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2024, 19:21

johnkuney requested review of this revision.Aug 21 2024, 19:21

Harbormaster completed remote builds in B30052: Diff 49310.Aug 21 2024, 19:21

update hash for js files

Harbormaster completed remote builds in B30053: Diff 49311.Aug 21 2024, 19:38

tobias_ruck requested changes to this revision.Aug 21 2024, 20:35

tobias_ruck added a subscriber: tobias_ruck.

tobias_ruck added inline comments.

web/explorer/explorer-server/templates/pages/address.html
3–4	is there a reason for this new line change? this is the cause for the indent removal below

This revision now requires changes to proceed.Aug 21 2024, 20:35

remove format change

Harbormaster completed remote builds in B30054: Diff 49312.Aug 21 2024, 20:48

update js file hash

Harbormaster completed remote builds in B30055: Diff 49313.Aug 21 2024, 20:50

so when I saved it did all that formatting...removed it though and just saved without autoformat on...

tobias_ruck accepted this revision.Aug 21 2024, 22:00

This revision is now accepted and ready to land.Aug 21 2024, 22:00

Closed by commit rABC9e12b2825253: [explorer] Remove extra pagination (authored by johnkuney). · Explain WhyAug 21 2024, 22:19

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC9e12b2825253: [explorer] Remove extra pagination.

Revision Contents
Changeset List

Path

Size

web/

explorer/

explorer-server/

code/

2 lines

1 line

1 line

templates/

pages/

346 lines

26 lines

11 lines

Diff 49311

web/explorer/explorer-server/code/address.js

Loading...

web/explorer/explorer-server/code/blocks.js

Loading...

web/explorer/explorer-server/code/txs.js

Loading...

web/explorer/explorer-server/templates/pages/address.html

Loading...

web/explorer/explorer-server/templates/pages/block.html

Loading...

web/explorer/explorer-server/templates/pages/blocks.html

Loading...