It is easy to accidentally write tests assuming that buildRandomProof() will produce proofs with random payout scripts. This is not the case. There does not appear to be good case for random proofs to payout to UNSPENDABLE_ECREG_PAYOUT_SCRIPT considering all tests pass without any modification.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC7aafd2f1c1e7: [avalanche] Make buildRandomProof use a random payout script
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- brp-random-payout
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 30119 Build 59771: Build Diff lint-circular-dependencies · build-debug · build-clang-tidy · build-clang · build-diff · build-without-wallet Build 59770: arc lint + arc unit