Differential D16780

[e.cash] Prevent core tech section height jumping
ClosedPublic
Actions

Authored by johnkuney on Sep 18 2024, 16:06.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCb9da1ee0a31e: [e.cash] Prevent core tech section height jumping

Summary

due to different content length the core tech section causes background shifts when going through
the different items.

Adding a min fixed height to the container to avoid this

Test Plan

preview site and check it out

Diff Detail

Repository

rABC Bitcoin ABC

Branch

coretechfix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30345
Build 60215: Build Diff
Build 60214: arc lint + arc unit

Event Timeline

johnkuney created this revision.Sep 18 2024, 16:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2024, 16:06

johnkuney requested review of this revision.Sep 18 2024, 16:06

Harbormaster completed remote builds in B30345: Diff 49712.Sep 18 2024, 16:06

johnkuney edited the summary of this revision. (Show Details)Sep 18 2024, 16:18

@bot preview-e.cash

teamcity awarded a token.Sep 19 2024, 13:11

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.89.41.69:41549 for the next 60 minutes.

bytesofman accepted this revision.Sep 19 2024, 13:55

This revision is now accepted and ready to land.Sep 19 2024, 13:55

Closed by commit rABCb9da1ee0a31e: [e.cash] Prevent core tech section height jumping (authored by johnkuney). · Explain WhySep 19 2024, 15:58

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCb9da1ee0a31e: [e.cash] Prevent core tech section height jumping.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

core-tech/

styles.js

8 lines

styles/

pages/

homepage.js

4 lines

Diff 49712

View Options

web/e.cash/components/core-tech/styles.js