[avalanche] Add a way to get stake contender vote status
ClosedPublic
Actions

Authored by roqqit on Oct 1 2024, 22:30.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC52b9f0503a48: [avalanche] Add a way to get stake contender vote status

Summary

This adds logic for determining the avalanche vote result based on the contents of the cache.

Note that the loop in the rejection case should not adversely impact performance since manual winners should be empty by default and user action would typically only introduce a handful of additional winners.

Test Plan

ninja check-avalanche-stakecontendercache_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-votestatus

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30458
Build 60435: Build Diff	lint-circular-dependencies · build-debug · build-clang · build-clang-tidy · build-diff · check-iguana · build-without-wallet
Build 60434: arc lint + arc unit

Event Timeline

roqqit created this revision.Oct 1 2024, 22:30

Owners added a reviewer: Restricted Owners Package.Oct 1 2024, 22:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2024, 22:30

roqqit requested review of this revision.Oct 1 2024, 22:30

Harbormaster completed remote builds in B30458: Diff 49881.Oct 1 2024, 22:49

Fabien requested changes to this revision.Oct 2 2024, 08:28

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/stakecontendercache.cpp
134	This is rejecting contenders that are not accepted but in the winner set. Is that the expected behavior ?

This revision now requires changes to proceed.Oct 2 2024, 08:28

roqqit requested review of this revision.Oct 2 2024, 16:14

roqqit added inline comments.

src/avalanche/stakecontendercache.cpp
134	Yes, and its needed for convergence. The only scenario where this happens is some nodes' local winner has been rejected by avalanche (local winner is the only contender that is initialized as in winner set). Those nodes will continue to accept blocks with their local winner until that winner has become invalidated, but they will still help the network converge on some final state.