Paths

Table of Contentst

Differential D17008

[Cashtab] Prevent token qty errors on listings for large quantities
ClosedPublic
Actions

Authored by bytesofman on Fri, Oct 25, 22:48.

Details

Reviewers

Kronkmeister

Group Reviewers

Restricted Project

Commits

rABC6f6a0a328c31: [Cashtab] Prevent token qty errors on listings for large quantities

Summary

Do all the math in Orderbook with BigInt and token satoshis. Do all the rendering with decimalized quantities.

This resolves errors caused by step calculations for large token quantitites with large decimals getting off because JS numbers.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

white-screen-on-select

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30845
Build 61203: Build Diff	cashtab-tests
Build 61202: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Oct 25, 22:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Oct 25, 22:48

Harbormaster completed remote builds in B30845: Diff 50442.Fri, Oct 25, 22:52

remove debug log, better comments, validation function should also do math with bigints

Harbormaster completed remote builds in B30846: Diff 50443.Fri, Oct 25, 23:16

bytesofman published this revision for review.Fri, Oct 25, 23:17

Kronkmeister accepted this revision.Fri, Oct 25, 23:49

This revision is now accepted and ready to land.Fri, Oct 25, 23:49

Closed by commit rABC6f6a0a328c31: [Cashtab] Prevent token qty errors on listings for large quantities (authored by bytesofman). · Explain WhyFri, Oct 25, 23:51

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC6f6a0a328c31: [Cashtab] Prevent token qty errors on listings for large quantities.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Agora/

OrderBook.js

119 lines

__tests__/

index.test.js

1 line

Diff 50442

View Options

cashtab/src/components/Agora/OrderBook.js

View Options

cashtab/src/components/Agora/tests/index.test.js

[Cashtab] Prevent token qty errors on listings for large quantitiesClosedPublicActions