[avalanche] Fix contender cache isEmpty return type
ClosedPublic
Actions

Authored by roqqit on Mon, Oct 28, 20:30.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC3a8cbaf3c108: [avalanche] Fix contender cache isEmpty return type

Summary

Looks like refactor error. Return type should obviously be bool.

Test Plan

ninja check-avalanche-stakecontendercache_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-bool-isempty

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30878
Build 61268: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 61267: arc lint + arc unit

Event Timeline

roqqit created this revision.Mon, Oct 28, 20:30

Owners added a reviewer: Restricted Owners Package.Mon, Oct 28, 20:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Oct 28, 20:30

roqqit requested review of this revision.Mon, Oct 28, 20:30

Harbormaster completed remote builds in B30878: Diff 50493.Mon, Oct 28, 21:30

Fabien accepted this revision.Mon, Oct 28, 22:00

This revision is now accepted and ready to land.Mon, Oct 28, 22:00

Closed by commit rABC3a8cbaf3c108: [avalanche] Fix contender cache isEmpty return type (authored by roqqit). · Explain WhyMon, Oct 28, 23:52

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC3a8cbaf3c108: [avalanche] Fix contender cache isEmpty return type.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

stakecontendercache.h

2 lines

Diff 50493

View Options

src/avalanche/stakecontendercache.h

[avalanche] Fix contender cache isEmpty return typeClosedPublicActions