Page MenuHomePhabricator
Differential D17058

Fix lock order inversion in promoteStakeContendersToTip
ClosedPublic
Actions

Authored by roqqit on Nov 1 2024, 17:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC88a5faa04223: Fix lock order inversion in promoteStakeContendersToTip
Summary

Scheduler thread calls:
updatedBlockTip: cs_peerManager -> cs_main
promoteStakeContendersToTip: cs_stakeContendercache -> cs_peerManager

But main thread is calling addStakeContender: cs_main -> cs_stakeContenderCache

Swapping the lock order in promoteStakeContendersToTip fixes TSAN

Test Plan
cmake -GNinja .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=thread
ninja check-avalanche-processor_tests

Diff Detail

Event Timeline

roqqit created this revision.Nov 1 2024, 17:39
Owners added a reviewer: Restricted Owners Package.Nov 1 2024, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2024, 17:39
roqqit edited the summary of this revision. (Show Details)Nov 1 2024, 17:43
Harbormaster completed remote builds in B30959: Diff 50604.Nov 1 2024, 18:03
roqqit updated this revision to Diff 50606.Nov 1 2024, 21:15

Fixed

roqqit published this revision for review.Nov 1 2024, 21:16
roqqit retitled this revision from WIP to Fix lock order inversion in promoteStakeContendersToTip.
roqqit edited the summary of this revision. (Show Details)
roqqit edited the test plan for this revision. (Show Details)
Fabien added a subscriber: Fabien.Nov 1 2024, 21:17

@bot build-tsan

teamcity awarded a token.Nov 1 2024, 21:18
Harbormaster completed remote builds in B30961: Diff 50606.Nov 1 2024, 21:34
roqqit added a comment.Nov 1 2024, 21:58

https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/845463?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false

passes

Fabien accepted this revision.Nov 1 2024, 21:59
This revision is now accepted and ready to land.Nov 1 2024, 21:59
Closed by commit rABC88a5faa04223: Fix lock order inversion in promoteStakeContendersToTip (authored by roqqit). · Explain WhyNov 1 2024, 22:12
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABC88a5faa04223: Fix lock order inversion in promoteStakeContendersToTip.

Revision Contents
Changeset List

PathSize
src/
avalanche/
2 lines

Diff 50606

View Options

src/avalanche/processor.cpp

Loading...