Differential D17092

[e.cash] Add eCash Poker to use-ecash page
ClosedPublic
Actions

Authored by Kronkmeister on Wed, Nov 6, 19:07.

Details

Reviewers

Mengerian

Group Reviewers

Restricted Project

Commits

rABCe78f9b2da495: [e.cash] Add eCash Poker to use-ecash page

Summary

Added eCashPoker section on e.cash/use-ecash and added ecash-poker-logo.png to the images folder

Test Plan

visit e.cash/use-ecash

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecashpoker

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31040
Build 61583: Build Diff
Build 61582: arc lint + arc unit

Event Timeline

Kronkmeister created this revision.Wed, Nov 6, 19:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 19:07

Harbormaster completed remote builds in B31040: Diff 50713.Wed, Nov 6, 19:07

changed button label from "visit ecash.poker" to "eCash Poker"

Harbormaster completed remote builds in B31041: Diff 50714.Wed, Nov 6, 19:16

Improved all 3 Button labels to be in line and have a descriptive CTA

Harbormaster completed remote builds in B31042: Diff 50715.Wed, Nov 6, 19:33

Kronkmeister published this revision for review.Wed, Nov 6, 20:16

Technically would be better if the button text changes for eLPS and Paybutton were in a separate Diff.

Looks good otherwise.

This revision is now accepted and ready to land.Wed, Nov 6, 21:25

Closed by commit rABCe78f9b2da495: [e.cash] Add eCash Poker to use-ecash page (authored by Kronkmeister). · Explain WhyWed, Nov 6, 21:28

This revision was automatically updated to reflect the committed changes.

Kronkmeister added a commit: rABCe78f9b2da495: [e.cash] Add eCash Poker to use-ecash page.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

use-ecash.js

19 lines

public/

images/

ecash-poker-logo.png

Diff 50713

View Options

web/e.cash/pages/use-ecash.js