Page MenuHomePhabricator

[e.cash] Add eCash Poker to use-ecash page
ClosedPublic

Authored by Kronkmeister on Nov 6 2024, 19:07.

Details

Reviewers
Mengerian
Group Reviewers
Restricted Project
Commits
rABCe78f9b2da495: [e.cash] Add eCash Poker to use-ecash page
Summary

Added eCashPoker section on e.cash/use-ecash and added ecash-poker-logo.png to the images folder

Test Plan

visit e.cash/use-ecash

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecashpoker
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31042
Build 61587: Build Diff
Build 61586: arc lint + arc unit

Event Timeline

changed button label from "visit ecash.poker" to "eCash Poker"

Improved all 3 Button labels to be in line and have a descriptive CTA

Mengerian added a subscriber: Mengerian.

Technically would be better if the button text changes for eLPS and Paybutton were in a separate Diff.

Looks good otherwise.

This revision is now accepted and ready to land.Nov 6 2024, 21:25