[avalanche] Do not modify the chaintip in stake contender test
ClosedPublic
Actions

Authored by roqqit on Nov 19 2024, 21:08.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCd74a3bd8a0e8: [avalanche] Do not modify the chaintip in stake contender test

Summary

We could take a lock on cs_main to do the modification here, but it's better to just set the mock time prior to mining the block in the first place.

Test Plan

This does not replicate on my machine but it should fix the CI TSAN failure:
https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcMasterTsan/853976?buildTab=log&linesState=91&logView=flowAware&focusLine=2282

cmake -GNinja .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=thread
ninja check-avalanche-processor_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-tsan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31207
Build 61914: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 61913: arc lint + arc unit

Event Timeline

roqqit created this revision.Nov 19 2024, 21:08

Owners added a reviewer: Restricted Owners Package.Nov 19 2024, 21:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2024, 21:08

roqqit requested review of this revision.Nov 19 2024, 21:08

@bot build-tsan

teamcity awarded a token.Nov 19 2024, 21:09

Fabien requested changes to this revision.Nov 19 2024, 21:11

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/processor_tests.cpp
2454 ↗	(On Diff #50960)	You should take the lock only once here ? Move the call into the below scoped lock

This revision now requires changes to proceed.Nov 19 2024, 21:11

roqqit retitled this revision from [avalanche] Add missing lock in stake contenders test to [avalanche] Do not modify the chaintip in stake contender test.Nov 19 2024, 21:23

roqqit edited the summary of this revision. (Show Details)

Better approach

@bot build-tsan

teamcity updated a token.Nov 19 2024, 21:24

Harbormaster completed remote builds in B31206: Diff 50960.Nov 19 2024, 21:39

Harbormaster completed remote builds in B31207: Diff 50961.Nov 19 2024, 21:49

Fabien accepted this revision.Nov 20 2024, 08:43

This revision is now accepted and ready to land.Nov 20 2024, 08:43

Closed by commit rABCd74a3bd8a0e8: [avalanche] Do not modify the chaintip in stake contender test (authored by roqqit). · Explain WhyNov 20 2024, 17:51

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCd74a3bd8a0e8: [avalanche] Do not modify the chaintip in stake contender test.