The theme got a little wild to maintain or easily swap values to create other theme options
With the redesign the color pallete was simplified, so cleaning up the theme here to remove unused properties
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC41a72fe465f1: [cashtab] Cleanup theme file
npm start and check nothing off color wise
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-cleanup-theme
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31542 Build 62581: Build Diff cashtab-tests Build 62580: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-lib@1.1.0 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 2s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1487 packages, and audited 3333 packages in 25s 323 packages are looking for funding run `npm fund` for details 4 vulnerabilities (2 moderate, 2 high) To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@3.2.4 build > node scripts/build.js Creating an optimized production build... Treating warnings as errors because process.env.CI = true. Most CI servers set it automatically. Failed to compile. [eslint] src/components/Common/Atoms.tsx Line 7:10: 'Link' is defined but never used @typescript-eslint/no-unused-vars Build cashtab-tests failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-lib@1.1.0 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 2s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1487 packages, and audited 3333 packages in 25s 323 packages are looking for funding run `npm fund` for details 4 vulnerabilities (2 moderate, 2 high) To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@3.2.6 build > node scripts/build.js Creating an optimized production build... Treating warnings as errors because process.env.CI = true. Most CI servers set it automatically. Failed to compile. [eslint] src/components/Common/Atoms.tsx Line 7:10: 'Link' is defined but never used @typescript-eslint/no-unused-vars Build cashtab-tests failed with exit code 1
Comment Actions
nice, Cashtab has needed this. Much more maintainable.
not sure about the +'40' thing but otherwise great improvement.
| cashtab/src/components/App/styles.js | ||
|---|---|---|
| 108 ↗ | (On Diff #51420) | why not another theme var here? what's going on with '+40' ? |
| cashtab/src/components/App/styles.js | ||
|---|---|---|
| 108 ↗ | (On Diff #51420) | yeah maybe I went too far with theme minimization, but this just a subtle shadow above the mobile menu bar that is the accent color, but it needs just a bit of transparency so was trying to just add on the aplha channel here to the base accent color so you only have to update the accent color value |