The locally selected stake winner should be treated as accepted by default and put in the winner set. This way, the cache can flip flop on the voted status without removing the local winner until it is invalidated.
Depends on D17336
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABCb1cea59f8291: [avalanche] Set local stake winner in the contender cache
ninja check check-functional
Make sure to cover the case where the selected quorum proof happens to be the local winner:
for I in {0..30}; do ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting || break ; doneDiff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sw-local-winner
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31619 Build 62735: Build Diff build-diff · build-clang-tidy · build-debug · build-clang · lint-circular-dependencies · build-without-wallet Build 62734: arc lint + arc unit
Event Timeline
| src/avalanche/processor.cpp | ||
|---|---|---|
| 914 | Promotion happens when updatedBlockTip is called. My understanding is there are no strong guarantees that updatedBlockTip is called before staking rewards are computed. The vote could theoretically be incorrect for a very short period (milliseconds) until promotion occurs. I am considering mitigating this by tracking the last block index that was promoted and then voting PENDING for blocks after that. | |
| 1062 | A near future patch will be doing this for the other potential winners. They are treated slightly differently in that winner 0 is in the winner set while winners 1+ are only accepted until they are finalized by the network. I could do that as part of this patch but I want to do it in the frame of mind that these are distinct behaviors and so deserve separated attention. | |
| src/avalanche/processor.cpp | ||
|---|---|---|
| 914 | I see, indeed updatedBlockTip is on the scheduler thread. But if this is a no-op, what will make the status be updated later ? Afaict this function is only called once | |
| src/avalanche/processor.cpp | ||
|---|---|---|
| 914 | It is also called in promoteStakeContendersToTip. One of the calls will succeed. | |