Sharing the reward ranking logic between the contender cache and peer manager makes it easier to reason about. This also cleans up the if statement in selectStakingRewardWinner that is difficult to read at a glance.
There is no change in behavior.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC11d2e76dd3c3: [avalanche] Refactor reward ranking logic into its own comparator
ninja check check-functional
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- reward-rank-comp
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31980 Build 63452: Build Diff build-clang-tidy · build-clang · build-diff · build-debug · lint-circular-dependencies · build-without-wallet Build 63451: arc lint + arc unit
Event Timeline
This comment was removed by Fabien.
Comment Actions
Tail of the build log:
/work /work/abc-ci-builds/lint-circular-dependencies A new circular dependency in the form of "avalanche/rewardrankcomparator -> avalanche/stakecontendercache -> avalanche/rewardrankcomparator" appears to have been introduced. A new circular dependency in the form of "avalanche/peermanager -> avalanche/rewardrankcomparator -> avalanche/stakecontendercache -> avalanche/peermanager" appears to have been introduced. /work/abc-ci-builds/lint-circular-dependencies Build lint-circular-dependencies failed with exit code 1