Differential D17538

[test] Make test_getpeerinfo more robust by using mocktime
ClosedPublic
Actions

Authored by roqqit on Wed, Jan 15, 17:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime

Summary

See title.

Depends on D17529

Test Plan

Run rpc_net multiple times to make sure it isn't flaky:

for X in {1..30} ; do ./test/functional/test_runner.py rpc_net || break ; done

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpc-net-mocktime

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32129
Build 63749: Build Diff	build-without-wallet · build-clang-tidy · build-clang · build-diff · build-debug
Build 63748: arc lint + arc unit

Event Timeline

roqqit created this revision.Wed, Jan 15, 17:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 15, 17:19

roqqit requested review of this revision.Wed, Jan 15, 17:19

roqqit mentioned this in D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.Wed, Jan 15, 17:20

Harbormaster completed remote builds in B32105: Diff 52213.Wed, Jan 15, 17:30

Fabien accepted this revision.Wed, Jan 15, 22:03

This revision is now accepted and ready to land.Wed, Jan 15, 22:03

Fabien requested changes to this revision.Wed, Jan 15, 22:03

Fabien added inline comments.

test/functional/rpc_net.py
116 ↗	(On Diff #52213)	You can now assert_equal

This revision now requires changes to proceed.Wed, Jan 15, 22:03

Use assert_equal

Remove errant newline

Harbormaster completed remote builds in B32129: Diff 52247.Thu, Jan 16, 18:11

Harbormaster completed remote builds in B32130: Diff 52248.

Fabien accepted this revision.Thu, Jan 16, 19:50

This revision is now accepted and ready to land.Thu, Jan 16, 19:50

Closed by commit rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime (authored by roqqit). · Explain WhyThu, Jan 16, 21:07

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime.

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_net.py

11 lines

Diff 52247

View Options

test/functional/rpc_net.py

[test] Make test_getpeerinfo more robust by using mocktimeClosedPublicActions