Differential D17616

[avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status
ClosedPublic
Actions

Authored by roqqit on Thu, Jan 30, 17:11.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCfd85bce1ebe4: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when…

Summary

It is unnecessary to take a lock on cs_stakingRewards unless there is a cache hit. There is no change in behavior.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-status-less-sr-lock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32265
Build 64020: Build Diff	build-clang-tidy · build-without-wallet · build-diff · lint-circular-dependencies · build-clang · build-debug
Build 64019: arc lint + arc unit

Event Timeline

roqqit created this revision.Thu, Jan 30, 17:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 30, 17:11

roqqit requested review of this revision.Thu, Jan 30, 17:11

Harbormaster completed remote builds in B32265: Diff 52454.Thu, Jan 30, 17:22

PiRK accepted this revision.Thu, Jan 30, 18:15

This revision is now accepted and ready to land.Thu, Jan 30, 18:15

Closed by commit rABCfd85bce1ebe4: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when… (authored by roqqit). · Explain WhyThu, Jan 30, 19:38

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCfd85bce1ebe4: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when….

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

15 lines

Diff 52454

View Options

src/avalanche/processor.cpp

[avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender statusClosedPublicActions